[Alpaca] Add block hash and timestamp #8723

Salim-belkhir · 2024-12-17T14:50:00Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- an extra field named block on the Operation object returned by the coin framework for stellar, tezos and xrp

📝 Description

Update listOperations for the coins module stellar, tezos and xrp. This change is needed because we need extra information about the block for each operation (the time and the hash of the block)

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-12-17T14:50:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 23, 2024 4:07pm

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Dec 23, 2024 4:07pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Dec 23, 2024 4:07pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Dec 23, 2024 4:07pm

sprohaszka-ledger

I am not confident with the Tezos update. It will create hundreds of requests.
Also, we can remove extra blockNumber field and create a mandatory block field.

libs/coin-modules/coin-stellar/src/bridge/buildOptimisticOperation.ts

libs/coin-modules/coin-stellar/src/network/horizon.ts

libs/coin-modules/coin-tezos/src/logic/listOperations.ts

libs/coin-framework/src/api/types.ts

libs/coin-modules/coin-tezos/src/logic/listOperations.ts

libs/coin-modules/coin-xrp/src/network/index.ts

github-actions · 2024-12-20T10:12:15Z

[Bot] Testing with 'Oxygen' ❌ 1 txs 💰 2 miss funds ($6.45) ⏲ 74s

❌ 1 specs have problems: Stellar
💰 2 specs may miss funds: Tezos, XRP

What is the bot and how does it work? Everything is documented here!

❌ 1 mutation errors

necessary accounts resynced in 0.51ms
▬ Stellar 5.5.0 on nanoSP 1.1.2
→ FROM undefined: 18.9999 XLM (4ops) (GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO on 44'/148'/0') sep5#0 js:2:stellar:GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO:sep5
max spendable ~17.9999
★ using mutation 'add USDC asset'
✔️ transaction 
    SEND 0 XLM
    TO 
    with fees=0.0005 XLM
STATUS (780ms)
  amount: 0 XLM
  estimated fees: 0.0005 XLM
  total spent: 0 XLM
errors: 
warnings: 
⚠️ Error: device action timeout. Recent events was:
{"text":"0.0005 XLM","x":36,"y":21,"w":58,"h":11}
{"text":"Tx Source","x":37,"y":7,"w":54,"h":9}
{"text":"GBPCBJ..NTKEMO","x":19,"y":21,"w":91,"h":11}
{"text":"Change Trust","x":28,"y":7,"w":73,"h":12}
{"text":"[email protected]","x":18,"y":21,"w":93,"h":11}
(totally spent 60.8s – ends at 2024-12-20T10:12:14.473Z)

⚠️ 4 spec hints

Spec Stellar:
- There are not enough accounts (2) to cover all mutations (4).
  Please increase the account target to at least 5 accounts
Spec Tezos:
- mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
- There are not enough accounts (1) to cover all mutations (7).
  Please increase the account target to at least 8 accounts
Spec XRP:
- There are not enough accounts (1) to cover all mutations (1).
  Please increase the account target to at least 2 accounts

Details of the 1 mutations

Spec Stellar (2)

Spec Stellar found 2 Stellar accounts. Will use Stellar 5.5.0 on nanoSP 1.1.2
undefined: 18.9999 XLM (4ops) (GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO on 44'/148'/0') sep5#0 js:2:stellar:GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO:sep5
undefined: 0 XLM (0ops) (GDTLR6ZNKY2HKZEMSSYRHOPXPQKWYY45WJQCR7FEWKVKYEPVBTVW42HZ on 44'/148'/1') sep5#1 js:2:stellar:GDTLR6ZNKY2HKZEMSSYRHOPXPQKWYY45WJQCR7FEWKVKYEPVBTVW42HZ:sep5
necessary accounts resynced in 0.51ms
▬ Stellar 5.5.0 on nanoSP 1.1.2
→ FROM undefined: 18.9999 XLM (4ops) (GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO on 44'/148'/0') sep5#0 js:2:stellar:GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO:sep5
max spendable ~17.9999
★ using mutation 'add USDC asset'
✔️ transaction 
    SEND 0 XLM
    TO 
    with fees=0.0005 XLM
STATUS (780ms)
  amount: 0 XLM
  estimated fees: 0.0005 XLM
  total spent: 0 XLM
errors: 
warnings: 
⚠️ Error: device action timeout. Recent events was:
{"text":"0.0005 XLM","x":36,"y":21,"w":58,"h":11}
{"text":"Tx Source","x":37,"y":7,"w":54,"h":9}
{"text":"GBPCBJ..NTKEMO","x":19,"y":21,"w":91,"h":11}
{"text":"Change Trust","x":28,"y":7,"w":73,"h":12}
{"text":"[email protected]","x":18,"y":21,"w":93,"h":11}
(totally spent 60.8s – ends at 2024-12-20T10:12:14.478Z)

Spec Tezos (failed)

Spec Tezos found 1 Tezos accounts (preload: 264ms). Will use TezosWallet 3.0.6 on nanoS 2.1.0
undefined: 0 XTZ (0ops) (tz1UodLb3BKQ4ATx2dytFv77hPe76SNVeTUd on 44'/1729'/0'/0') tezbox#0 js:2:tezos:02b776444e7af7dd410d58810c3543ff862f50b9cb0115a72f289a3ae3c91fb24e:tezbox

This SEED does not have Tezos. Please send funds to tz1UodLb3BKQ4ATx2dytFv77hPe76SNVeTUd

Spec XRP (failed)

Spec XRP found 1 XRP accounts. Will use XRP 2.4.1 on nanoS 2.1.0
undefined: 0 XRP (0ops) (rBERjFwyKj4uHd1coeHX84cLGkzUs5s7Zb on 44'/144'/0'/0/0) #0 js:2:ripple:rBERjFwyKj4uHd1coeHX84cLGkzUs5s7Zb:

This SEED does not have XRP. Please send funds to rBERjFwyKj4uHd1coeHX84cLGkzUs5s7Zb

Details of the 11 uncovered mutations

Spec Stellar (3)

move ~50% XLM: XLM balance is too low (1)
Send max XLM: XLM balance is too low (1)
move ~50% USDC asset: XLM balance is too low (1)

Spec Tezos (7)

send unrevealed:
send revealed:
send max (non delegating):
delegate unrevealed:
delegate revealed:
undelegate unrevealed:
undelegate revealed:

Spec XRP (1)

move ~50%:

Portfolio ($6.45) – Details of the 3 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Stellar (2)	4 ops , 17.9999 XLM ($6.45)	💪 999+	`GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO`
Tezos (1)	0 ops , 0 XTZ ($0.00)	❌	`tz1UodLb3BKQ4ATx2dytFv77hPe76SNVeTUd`
XRP (1)	0 ops , 0 XRP ($0.00)	❌	`rBERjFwyKj4uHd1coeHX84cLGkzUs5s7Zb`

undefined: 18.9999 XLM (4ops) (GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO on 44'/148'/0') sep5#0 js:2:stellar:GBPCBJGLI5PI5EQTERHNAXN5JQNHPERZAWGUBUG6RPWIS7FEYJNTKEMO:sep5
undefined: 0 XLM (0ops) (GDTLR6ZNKY2HKZEMSSYRHOPXPQKWYY45WJQCR7FEWKVKYEPVBTVW42HZ on 44'/148'/1') sep5#1 js:2:stellar:GDTLR6ZNKY2HKZEMSSYRHOPXPQKWYY45WJQCR7FEWKVKYEPVBTVW42HZ:sep5
undefined: 0 XTZ (0ops) (tz1UodLb3BKQ4ATx2dytFv77hPe76SNVeTUd on 44'/1729'/0'/0') tezbox#0 js:2:tezos:02b776444e7af7dd410d58810c3543ff862f50b9cb0115a72f289a3ae3c91fb24e:tezbox
undefined: 0 XRP (0ops) (rBERjFwyKj4uHd1coeHX84cLGkzUs5s7Zb on 44'/144'/0'/0/0) #0 js:2:ripple:rBERjFwyKj4uHd1coeHX84cLGkzUs5s7Zb:

Performance ⏲ 74s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	267ms	10.1s	0.79ms	780ms	N/A	N/A	N/A	N/A
Stellar (1)	0.70ms	3.8s	0.79ms	780ms	N/A	N/A	N/A	N/A
Tezos (0)	264ms	4.9s	N/A	N/A	N/A	N/A	N/A	N/A
XRP (0)	2.62ms	1369ms	N/A	N/A	N/A	N/A	N/A	N/A

What is the bot and how does it work? Everything is documented here!

libs/coin-modules/coin-tezos/src/logic/listOperations.ts

github-actions · 2024-12-24T09:13:05Z

[Bot] Testing with 'Nitrogen' ❌ 1 txs ($7.30) ⏲ 69.9s

❌ 1 specs have problems: Tezos

What is the bot and how does it work? Everything is documented here!

❌ 1 mutation errors

necessary accounts resynced in 0.20ms
▬ TezosWallet 3.0.6 on nanoS 2.1.0
→ FROM undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~5.28774
★ using mutation 'send unrevealed'
→ TO undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND 2.643872 XTZ
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.0005
with gasLimit=600
with storageLimit=277
(estimatedFees 0.000563)
STATUS (636ms)
  amount: 2.643872 XTZ
  estimated fees: 0.000563 XTZ
  total spent: 2.644435 XTZ
errors: 
warnings: 
⚠️ Error: device action timeout. Recent events was:
{"text":"Review operation","x":13,"y":17,"w":107,"h":11}
{"text":"Operation (0)","x":26,"y":-1,"w":94,"h":11}
{"text":"Reveal","x":47,"y":10,"w":81,"h":11}
(totally spent 61s – ends at 2024-12-24T09:13:04.609Z)

⚠️ 2 spec hints

Spec Tezos:
- mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
- There are not enough accounts (3) to cover all mutations (7).
  Please increase the account target to at least 8 accounts

Details of the 1 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 190ms). Will use TezosWallet 3.0.6 on nanoS 2.1.0
undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
undefined: 0 XTZ (4ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.20ms
▬ TezosWallet 3.0.6 on nanoS 2.1.0
→ FROM undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~5.28774
★ using mutation 'send unrevealed'
→ TO undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND 2.643872 XTZ
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.0005
with gasLimit=600
with storageLimit=277
(estimatedFees 0.000563)
STATUS (636ms)
  amount: 2.643872 XTZ
  estimated fees: 0.000563 XTZ
  total spent: 2.644435 XTZ
errors: 
warnings: 
⚠️ Error: device action timeout. Recent events was:
{"text":"Review operation","x":13,"y":17,"w":107,"h":11}
{"text":"Operation (0)","x":26,"y":-1,"w":94,"h":11}
{"text":"Reveal","x":47,"y":10,"w":81,"h":11}
(totally spent 61s – ends at 2024-12-24T09:13:04.612Z)

Details of the 6 uncovered mutations

Spec Tezos (6)

send revealed: balance is too low (2)
send max (non delegating): balance is too low (2)
delegate unrevealed: balance is too low (2)
delegate revealed: balance is too low (2)
undelegate unrevealed: balance is too low (2)
undelegate revealed: balance is too low (2)

Portfolio ($7.30) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Tezos (3)	156 ops , 5.28869 XTZ ($7.30)	👍 182	`tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF`

undefined: 5.28869 XTZ (152ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
undefined: 0 XTZ (4ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
undefined: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox

Performance ⏲ 69.9s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	190ms	3.7s	0.55ms	636ms	N/A	N/A	N/A	N/A
Tezos (2)	190ms	3.7s	0.55ms	636ms	N/A	N/A	N/A	N/A

What is the bot and how does it work? Everything is documented here!

github-actions · 2024-12-24T10:49:01Z

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 6ms

What is the bot and how does it work? Everything is documented here!

Details of the 0 mutations

Portfolio ($0.00) – Details of the 0 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?

Performance ⏲ 6ms

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A

What is the bot and how does it work? Everything is documented here!

Wozacosta

👍

Because I made the changes

[Alpaca] Add block hash and timestamp

3d9ea5c

Salim-belkhir requested a review from a team as a code owner December 17, 2024 14:50

Salim-belkhir marked this pull request as draft December 17, 2024 14:50

github-actions bot assigned Salim-belkhir Dec 17, 2024

work on xrp coin module

00cf86d

vercel bot deployed to Preview – web-tools December 18, 2024 13:40 View deployment

Add imp for stellar

96e407c

vercel bot deployed to Preview – web-tools December 18, 2024 17:11 View deployment

Some corrections of tests for xrp and get of ops

64dde66

vercel bot deployed to Preview – web-tools December 19, 2024 08:57 View deployment

handle of tezos coin

3956f1c

vercel bot deployed to Preview – web-tools December 19, 2024 14:13 View deployment

add of changeset

12e9475

Salim-belkhir marked this pull request as ready for review December 19, 2024 14:57

sprohaszka-ledger previously requested changes Dec 20, 2024

View reviewed changes

sprohaszka-ledger requested a review from a team December 20, 2024 14:59

vercel bot deployed to Preview – web-tools December 23, 2024 10:35 View deployment

vercel bot deployed to Preview – web-tools December 23, 2024 10:47 View deployment

Corrections of reviews

7d18f34

Salim-belkhir force-pushed the support/alpaca-block-hash-and-time branch from 3dd3cc0 to 7d18f34 Compare December 23, 2024 11:16

vercel bot had a problem deploying to Preview – web-tools December 23, 2024 11:18 Failure

Wozacosta reviewed Dec 23, 2024

View reviewed changes

libs/coin-modules/coin-tezos/src/logic/listOperations.ts Outdated Show resolved Hide resolved

correction with Samy comments

da3ef95

vercel bot deployed to Preview – web-tools December 23, 2024 16:07 View deployment

Wozacosta approved these changes Dec 24, 2024

View reviewed changes

Wozacosta merged commit 2ae713b into develop Dec 24, 2024
54 of 59 checks passed

Wozacosta deleted the support/alpaca-block-hash-and-time branch December 24, 2024 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alpaca] Add block hash and timestamp #8723

[Alpaca] Add block hash and timestamp #8723

Salim-belkhir commented Dec 17, 2024 •

edited

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading

sprohaszka-ledger left a comment

github-actions bot commented Dec 20, 2024

Spec Stellar (2)

Spec Tezos (failed)

Spec XRP (failed)

Spec Stellar (3)

Spec Tezos (7)

Spec XRP (1)

github-actions bot commented Dec 24, 2024

Spec Tezos (3)

Spec Tezos (6)

github-actions bot commented Dec 24, 2024

Wozacosta left a comment

[Alpaca] Add block hash and timestamp #8723

[Alpaca] Add block hash and timestamp #8723

Conversation

Salim-belkhir commented Dec 17, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Dec 17, 2024 • edited Loading

sprohaszka-ledger left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 20, 2024

[Bot] Testing with 'Oxygen' ❌ 1 txs 💰 2 miss funds ($6.45) ⏲ 74s

Spec Stellar (2)

Spec Tezos (failed)

Spec XRP (failed)

Spec Stellar (3)

Spec Tezos (7)

Spec XRP (1)

github-actions bot commented Dec 24, 2024

[Bot] Testing with 'Nitrogen' ❌ 1 txs ($7.30) ⏲ 69.9s

Spec Tezos (3)

Spec Tezos (6)

github-actions bot commented Dec 24, 2024

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 6ms

Wozacosta left a comment

Choose a reason for hiding this comment

Salim-belkhir commented Dec 17, 2024 •

edited

Loading

vercel bot commented Dec 17, 2024 •

edited

Loading