Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/cosmos crypto org draft #8646

Closed
wants to merge 17 commits into from
Closed

Conversation

qperrot
Copy link
Contributor

@qperrot qperrot commented Dec 9, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 9, 2024 3:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 9, 2024 3:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 9, 2024 3:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 9, 2024 3:58pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Dec 9, 2024
@qperrot qperrot closed this Dec 9, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 9, 2024

Desktop Bundle Checks

Comparing d7b3a2a against efbbce1.

πŸš€ renderer bundle size decreased (38.5mb -> 36.7mb). Thanks ❀️
πŸš€ bip39 library is no longer duplicated in renderer
πŸš€ web3-utils library is no longer duplicated in renderer
πŸš€ moment library is no longer duplicated in renderer
πŸš€ @cosmjs/proto-signing library is no longer duplicated in renderer
πŸš€ @cosmjs/amino library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing d7b3a2a against efbbce1.

πŸš€ main.ios.jsbundle bundle size decreased (64.4mb -> 62.5mb). Thanks ❀️
πŸš€ main.android.jsbundle bundle size decreased (64.4mb -> 62.5mb). Thanks ❀️

@qperrot qperrot deleted the support/cosmos-crypto-org_draft branch December 10, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant