Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PulseChain network #8310

Closed
wants to merge 1 commit into from
Closed

Conversation

bretep
Copy link

@bretep bretep commented Nov 6, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.

πŸ“ Description

Adds support for the PulseChain network.
Please refer to #7607 which was pending being merged.

Testing

I've tested this PR with LedgerHQ/app-ethereum#626 installed on:

  • Ledger Stax
  • Nano S Plus

Dependencies

This PR requires the changes introduced in LedgerHQ/app-ethereum#626.


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Add tests for the PulseChain network

Add changeset
@bretep bretep requested review from a team as code owners November 6, 2024 04:30
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Nov 6, 2024 4:36am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:36am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 4:36am

Copy link

vercel bot commented Nov 6, 2024

Someone is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs cli fork Pull request base branch comes from a fork. labels Nov 6, 2024
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Nov 22, 2024
@github-actions github-actions bot closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM Stale ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant