Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linea goerli] Add missing information #5927

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[Linea goerli] Add missing information #5927

merged 2 commits into from
Jan 18, 2024

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Jan 16, 2024

πŸ“ Description

Some information was missing in the linea goerli integration:

  • Correct explorer URI
  • Usage of testnet units
  • SVG file for goerli

❓ Context

  • JIRA or GitHub link: pre-release

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • [ ] Impact of the changes:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this Jan 16, 2024
@lvndry lvndry requested review from a team as code owners January 16, 2024 16:25
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 16, 2024 5:02pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 5:02pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 5:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 5:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2024 5:02pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Jan 16, 2024
@lvndry lvndry removed the request for review from a team January 16, 2024 16:25
Copy link

[Bot] Testing with 'Nitrogen' πŸ’° 1 miss funds ($0.00) ⏲ 2min 19s

πŸ’° 1 specs may miss funds: Linea Goerli

What is the bot and how does it work? Everything is documented here!

1 critical spec errors

Spec Arbitrum Goerli failed!

Error: getaddrinfo ENOTFOUND api-goerli.arbiscan.io
⚠️ 1 spec hints
  • Spec Linea Goerli:
    • There are not enough accounts (1) to cover all mutations (3).
      Please increase the account target to at least 4 accounts
Details of the 0 mutations

Spec Arbitrum Goerli (failed)


Spec Linea Goerli (failed)

Spec Linea Goerli found 1 Linea Goerli accounts (preload: 1170ms). Will use Ethereum 1.10.3 on nanoS 2.1.0
Linea Goerli 1 cross: 0 𝚝ETH (0ops) (0x60A4E7657D8df28594ac4A06CDe01E18E948a892 on 44'/60'/0'/0/0) #0 js:2:linea_goerli:0x60A4E7657D8df28594ac4A06CDe01E18E948a892:

This SEED does not have Linea Goerli. Please send funds to 0x60A4E7657D8df28594ac4A06CDe01E18E948a892

Details of the 6 uncovered mutations

Spec Arbitrum Goerli (3)

  • move 50%:
  • send max:
  • move some ERC20 like (ERC20, BEP20, etc...):

Spec Linea Goerli (3)

  • move 50%:
  • send max:
  • move some ERC20 like (ERC20, BEP20, etc...):
Portfolio ($0.00) – Details of the 2 currencies
Spec (accounts) State Remaining Runs (est) funds?
Arbitrum Goerli (0) 0 ops , πŸ€·β€β™‚οΈ ❌ ``
Linea Goerli (1) 0 ops , 0 𝚝ETH ($0.00) ❌ 0x60A4E7657D8df28594ac4A06CDe01E18E948a892
Linea Goerli 1 cross: 0 𝚝ETH (0ops) (0x60A4E7657D8df28594ac4A06CDe01E18E948a892 on 44'/60'/0'/0/0) #0 js:2:linea_goerli:0x60A4E7657D8df28594ac4A06CDe01E18E948a892:
Performance ⏲ 2min 19s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 1287ms 1995ms N/A N/A N/A N/A N/A N/A
Arbitrum Goerli (0) 117ms N/A N/A N/A N/A N/A N/A N/A
Linea Goerli (0) 1170ms 1995ms N/A N/A N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

Copy link

[Bot] Testing with 'Nitrogen' ($0.00) ⏲ 2min 20s

What is the bot and how does it work? Everything is documented here!

1 critical spec errors

Spec Linea Goerli failed!

LedgerAPI4xx: API HTTP 403
Details of the 0 mutations

Spec Linea Goerli (failed)


Details of the 3 uncovered mutations

Spec Linea Goerli (3)

  • move 50%:
  • send max:
  • move some ERC20 like (ERC20, BEP20, etc...):
Portfolio ($0.00) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Linea Goerli (0) 0 ops , πŸ€·β€β™‚οΈ ❌ ``

Performance ⏲ 2min 20s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 935ms N/A N/A N/A N/A N/A N/A N/A
Linea Goerli (0) 935ms N/A N/A N/A N/A N/A N/A N/A

What is the bot and how does it work? Everything is documented here!

@lvndry lvndry merged commit e9b931a into develop Jan 18, 2024
60 of 62 checks passed
@lvndry lvndry deleted the bugfix/linea-goerli branch January 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant