Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix LIVE-9694 #5041

Merged
merged 1 commit into from
Oct 13, 2023
Merged

test: fix LIVE-9694 #5041

merged 1 commit into from
Oct 13, 2023

Conversation

gre
Copy link
Contributor

@gre gre commented Oct 12, 2023

πŸ“ Description

Fixes LIVE-9694 by effectively stopping Lottie animations.

❓ Context

  • Impacted projects: LLD tests
  • Linked resource(s): LIVE-9694

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

⚠️ No Changeset found

Latest commit: 1c8739a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gre
Copy link
Contributor Author

gre commented Oct 12, 2023

@gre

Generating screenshots: workflow ended

Jobs status:
βœ… - generate-screenshots-mac
βœ… - generate-screenshots-linux
βœ… - generate-screenshots-windows

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 12, 2023 0:46am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 12, 2023 0:46am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:46am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 12, 2023 0:46am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 0:46am

@github-actions github-actions bot added the desktop Has changes in LLD label Oct 12, 2023
@gre gre marked this pull request as draft October 12, 2023 16:07
@KVNLS KVNLS self-requested a review October 13, 2023 07:01
Copy link
Contributor

@beths-ledger beths-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-keeping with what we do elsewhere, and good to see the comments

@gre gre marked this pull request as ready for review October 13, 2023 11:23
@gre gre merged commit b64bddd into develop Oct 13, 2023
30 of 34 checks passed
@gre gre deleted the support/live-9694 branch October 13, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants