-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new app-exchange APDU #4954
Conversation
🦋 Changeset detectedLatest commit: d134dd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
4617474
to
2972025
Compare
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
5813e37
to
80a6b7a
Compare
Signed-off-by: Stéphane Prohaszka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but my knowledge about this is super limited
@@ -12,7 +14,11 @@ export const enum ExchangeTypes { | |||
Swap = 0x00, | |||
Sell = 0x01, | |||
Fund = 0x02, | |||
SwapNg = 0x03, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What means Ng sufix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is for Next Gen :P
It comes from the firmware team, for consistency I keep their naming.
It appears this PR was merged without having a recent enough rebase which caused (due to possible increase of lint strictness?) Could you fix it asap? Thanks https://github.com/LedgerHQ/ledger-live/actions/runs/6656746107/job/18089984246
|
📝 Description
Add calls to new APDU coming with new app-exchange version.
Add Moonpay signature.
Update exchange partner signature.
Add unit test and integration test.
Update the
hw-app-exchange
README to ease the use of Speculos.❓ Context
hw-app-echange
,live-common
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.