Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new app-exchange APDU #4954

Merged
merged 13 commits into from
Oct 26, 2023

Conversation

sprohaszka-ledger
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger commented Oct 6, 2023

📝 Description

Add calls to new APDU coming with new app-exchange version.
Add Moonpay signature.
Update exchange partner signature.
Add unit test and integration test.
Update the hw-app-exchange README to ease the use of Speculos.

❓ Context

  • Impacted projects: hw-app-echange, live-common
  • Linked resource(s): LIVE-9336

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: d134dd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@ledgerhq/hw-app-exchange Minor
@ledgerhq/live-common Minor
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
live-mobile Patch
web-tools Patch
@ledgerhq/test-utils Patch
dummy-wallet-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-common-tools ❌ Failed (Inspect) Oct 17, 2023 4:50pm
web-tools ❌ Failed (Inspect) Oct 17, 2023 4:50pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 4:50pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 4:50pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 4:50pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 4:50pm

Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Signed-off-by: Stéphane Prohaszka <[email protected]>
Copy link
Contributor

@sarneijim sarneijim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but my knowledge about this is super limited

@@ -12,7 +14,11 @@ export const enum ExchangeTypes {
Swap = 0x00,
Sell = 0x01,
Fund = 0x02,
SwapNg = 0x03,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What means Ng sufix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is for Next Gen :P
It comes from the firmware team, for consistency I keep their naming.

@sprohaszka-ledger sprohaszka-ledger merged commit 3b2b2bf into develop Oct 26, 2023
51 of 56 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the feat/LIVE-9636-new-app-exchange branch October 26, 2023 08:52
@gre
Copy link
Contributor

gre commented Oct 26, 2023

It appears this PR was merged without having a recent enough rebase which caused (due to possible increase of lint strictness?) develop to go ❌ since this morning.

Could you fix it asap? Thanks

https://github.com/LedgerHQ/ledger-live/actions/runs/6656746107/job/18089984246

@ledgerhq/hw-app-exchange:lint: /home/runner/work/ledger-live/ledger-live/libs/ledgerjs/packages/hw-app-exchange/src/Exchange.integ.test.ts
@ledgerhq/hw-app-exchange:lint:    30:59  error  Replace `·await·appExchangeDatasetTest(⏎······legacySignFormat,⏎····` with `⏎······await·appExchangeDatasetTest(legacySignFormat`  prettier/prettier
@ledgerhq/hw-app-exchange:lint:    67:59  error  Replace `·await·appExchangeDatasetTest(⏎······ngSignFormat,⏎····` with `⏎······await·appExchangeDatasetTest(ngSignFormat`          prettier/prettier
@ledgerhq/hw-app-exchange:lint:   106:59  error  Replace `·await·appExchangeDatasetTest(⏎······ngSignFormat,⏎····` with `⏎······await·appExchangeDatasetTest(ngSignFormat`          prettier/prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants