[bugfix] Remove old obsolete hack of Tezos gas limit #4866

ghost · 2023-09-27T15:48:59Z

📝 Description

A long time ago this crazy feature was implemented https://ledgerhq.atlassian.net/browse/LL-8821
It recently broke, causing delegate and undelegate transactions to fail with insufficient gas/fees.
The fix is to remove the crazy feature... making gas limit and fees computation to work like they should.
(confirmed with product that no one needs it anymore)

❓ Context

Impacted projects: LLC
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-8482

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

🚀 Expectations to reach

changeset-bot · 2023-09-27T15:49:02Z

🦋 Changeset detected

Latest commit: 06a5b59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@ledgerhq/live-common	Patch
@ledgerhq/live-cli	Patch
ledger-live-desktop	Patch
live-mobile	Patch
web-tools	Patch
@ledgerhq/test-utils	Patch
dummy-wallet-app	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-09-27T15:49:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2023 9:35am
live-common-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2023 9:35am

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Oct 2, 2023 9:35am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Oct 2, 2023 9:35am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Oct 2, 2023 9:35am

github-actions · 2023-09-27T16:02:46Z

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.51) ⏲ 19.8s

❌ 2 mutation errors

necessary accounts resynced in 0.38ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'delegate unrevealed'
✔️ transaction 
DELEGATE 0 XTZ
TO tz1aRoaRhSpRYvFdyvgWLL6TGyRoGF51wDjM
with fees=0.00037
with gasLimit=200
with storageLimit=0
(estimatedFees 0.000744)
STATUS (783ms)
  amount: 0 XTZ
  estimated fees: 0.000744 XTZ
  total spent: 0.000744 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000744",
+   "Fee": "0.000661 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-27T16:02:45.546Z)

necessary accounts resynced in 0.32ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send unrevealed'
→ TO Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
✔️ transaction 
SEND 0.837296 XTZ
TO tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF
with fees=0.000375
with gasLimit=201
with storageLimit=0
(estimatedFees 0.000749)
STATUS (849ms)
  amount: 0.837296 XTZ
  estimated fees: 0.000749 XTZ
  total spent: 0.838045 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "0.837296",
+   "Amount": "0.837296 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-27T16:02:45.555Z)

⚠️ 2 spec hints

Spec Tezos:
- mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
- There are not enough accounts to cover all mutations. Please increase the account target to at least 8 accounts

Details of the 2 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 261ms). Will use TezosWallet 2.4.2 on nanoS 2.1.0
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.38ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'delegate unrevealed'
✔️ transaction 
DELEGATE 0 XTZ
TO tz1aRoaRhSpRYvFdyvgWLL6TGyRoGF51wDjM
with fees=0.00037
with gasLimit=200
with storageLimit=0
(estimatedFees 0.000744)
STATUS (783ms)
  amount: 0 XTZ
  estimated fees: 0.000744 XTZ
  total spent: 0.000744 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000744",
+   "Fee": "0.000661 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-27T16:02:45.562Z)
necessary accounts resynced in 0.32ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send unrevealed'
→ TO Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
✔️ transaction 
SEND 0.837296 XTZ
TO tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF
with fees=0.000375
with gasLimit=201
with storageLimit=0
(estimatedFees 0.000749)
STATUS (849ms)
  amount: 0.837296 XTZ
  estimated fees: 0.000749 XTZ
  total spent: 0.838045 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "0.837296",
+   "Amount": "0.837296 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-27T16:02:45.566Z)

Details of the 5 uncovered mutations

Spec Tezos (5)

send revealed: balance is too low (1)
send max (non delegating): balance is too low (1)
delegate revealed: balance is too low (1)
undelegate unrevealed: balance is too low (1)
undelegate revealed: balance is too low (1)

Portfolio ($3.51) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Tezos (3)	150 ops , 5.35484 XTZ ($3.51)	👍 249	`tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF`

Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox

Performance ⏲ 19.8s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	261ms	4.1s	1.01ms	1632ms	N/A	N/A	N/A	N/A
Tezos (2)	261ms	4.1s	1.01ms	1632ms	N/A	N/A	N/A	N/A

github-actions · 2023-09-28T05:26:32Z

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.49) ⏲ 19.5s

❌ 2 mutation errors

necessary accounts resynced in 0.35ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send max (non delegating)'
→ TO Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
✔️ transaction 
SEND MAX
TO tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn
with fees=0.000575
with gasLimit=701
with storageLimit=0
(estimatedFees 0.000949)
STATUS (707ms)
  amount: 3.678358 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 3.679307 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "3.678358",
+   "Amount": "3.678358 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-28T05:26:31.510Z)

necessary accounts resynced in 0.34ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send max (non delegating)'
→ TO Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND MAX
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.000575
with gasLimit=701
with storageLimit=257
(estimatedFees 0.000949)
STATUS (956ms)
  amount: 1.610341 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 1.61129 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "1.610341",
+   "Amount": "1.610341 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-28T05:26:31.514Z)

⚠️ 2 spec hints

Spec Tezos:
- mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
- There are not enough accounts to cover all mutations. Please increase the account target to at least 8 accounts

Details of the 2 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 187ms). Will use TezosWallet 2.4.2 on nanoS 2.1.0
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.35ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send max (non delegating)'
→ TO Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
✔️ transaction 
SEND MAX
TO tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn
with fees=0.000575
with gasLimit=701
with storageLimit=0
(estimatedFees 0.000949)
STATUS (707ms)
  amount: 3.678358 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 3.679307 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "3.678358",
+   "Amount": "3.678358 XTZ",
  }
(totally spent 3.1s – ends at 2023-09-28T05:26:31.520Z)
necessary accounts resynced in 0.34ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send max (non delegating)'
→ TO Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND MAX
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.000575
with gasLimit=701
with storageLimit=257
(estimatedFees 0.000949)
STATUS (956ms)
  amount: 1.610341 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 1.61129 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "1.610341",
+   "Amount": "1.610341 XTZ",
  }
(totally spent 3.3s – ends at 2023-09-28T05:26:31.523Z)

Details of the 6 uncovered mutations

Spec Tezos (6)

send unrevealed: balance is too low (1)
send revealed: balance is too low (1)
delegate unrevealed: balance is too low (1)
delegate revealed: balance is too low (1)
undelegate unrevealed: balance is too low (1)
undelegate revealed: balance is too low (1)

Portfolio ($3.49) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Tezos (3)	150 ops , 5.35484 XTZ ($3.49)	👍 249	`tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF`

Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox

Performance ⏲ 19.5s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	187ms	3.9s	1.00ms	1663ms	N/A	N/A	N/A	N/A
Tezos (2)	187ms	3.9s	1.00ms	1663ms	N/A	N/A	N/A	N/A

github-actions · 2023-09-28T08:05:15Z

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.51) ⏲ 21.3s

❌ 2 mutation errors

necessary accounts resynced in 0.35ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send unrevealed'
→ TO Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
✔️ transaction 
SEND 1.839179 XTZ
TO tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn
with fees=0.000375
with gasLimit=201
with storageLimit=0
(estimatedFees 0.000749)
STATUS (929ms)
  amount: 1.839179 XTZ
  estimated fees: 0.000749 XTZ
  total spent: 1.839928 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "XTZ 1.839179",
+   "Amount": "1.839179 XTZ",
  }
(totally spent 3.8s – ends at 2023-09-28T08:05:14.464Z)

necessary accounts resynced in 0.33ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'delegate unrevealed'
✔️ transaction 
DELEGATE 0 XTZ
TO tz1P2Po7YM526ughEsRbY4oR9zaUPDZjxFrb
with fees=0.00037
with gasLimit=200
with storageLimit=0
(estimatedFees 0.000744)
STATUS (1051ms)
  amount: 0 XTZ
  estimated fees: 0.000744 XTZ
  total spent: 0.000744 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "XTZ 0.000744",
+   "Fee": "0.000661 XTZ",
  }
(totally spent 3.8s – ends at 2023-09-28T08:05:14.504Z)

⚠️ 2 spec hints

Spec Tezos:
- mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
- There are not enough accounts to cover all mutations. Please increase the account target to at least 8 accounts

Details of the 2 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 196ms). Will use TezosWallet 2.4.2 on nanoS 2.1.0
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.35ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send unrevealed'
→ TO Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
✔️ transaction 
SEND 1.839179 XTZ
TO tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn
with fees=0.000375
with gasLimit=201
with storageLimit=0
(estimatedFees 0.000749)
STATUS (929ms)
  amount: 1.839179 XTZ
  estimated fees: 0.000749 XTZ
  total spent: 1.839928 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Amount'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Amount": "XTZ 1.839179",
+   "Amount": "1.839179 XTZ",
  }
(totally spent 3.8s – ends at 2023-09-28T08:05:14.510Z)
necessary accounts resynced in 0.33ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'delegate unrevealed'
✔️ transaction 
DELEGATE 0 XTZ
TO tz1P2Po7YM526ughEsRbY4oR9zaUPDZjxFrb
with fees=0.00037
with gasLimit=200
with storageLimit=0
(estimatedFees 0.000744)
STATUS (1051ms)
  amount: 0 XTZ
  estimated fees: 0.000744 XTZ
  total spent: 0.000744 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "XTZ 0.000744",
+   "Fee": "0.000661 XTZ",
  }
(totally spent 3.8s – ends at 2023-09-28T08:05:14.512Z)

Details of the 5 uncovered mutations

Spec Tezos (5)

send revealed: balance is too low (1)
send max (non delegating): balance is too low (1)
delegate revealed: balance is too low (1)
undelegate unrevealed: balance is too low (1)
undelegate revealed: balance is too low (1)

Portfolio ($3.51) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Tezos (3)	150 ops , 5.35484 XTZ ($3.51)	👍 249	`tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF`

Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox

Performance ⏲ 21.3s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	196ms	4.2s	1.08ms	1980ms	N/A	N/A	N/A	N/A
Tezos (2)	196ms	4.2s	1.08ms	1980ms	N/A	N/A	N/A	N/A

github-actions · 2023-09-28T08:24:04Z

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.49) ⏲ 20.9s

❌ 2 mutation errors

necessary accounts resynced in 0.45ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send max (non delegating)'
→ TO Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND MAX
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.000575
with gasLimit=701
with storageLimit=257
(estimatedFees 0.000949)
STATUS (954ms)
  amount: 3.614108 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 3.615057 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000949 XTZ",
+   "Fee": "0.000866 XTZ",
  }
(totally spent 3.5s – ends at 2023-09-28T08:24:02.209Z)

necessary accounts resynced in 0.39ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send max (non delegating)'
→ TO Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
✔️ transaction 
SEND MAX
TO tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF
with fees=0.000575
with gasLimit=701
with storageLimit=0
(estimatedFees 0.000949)
STATUS (735ms)
  amount: 1.674591 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 1.67554 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000949 XTZ",
+   "Fee": "0.000866 XTZ",
  }
(totally spent 3.7s – ends at 2023-09-28T08:24:02.213Z)

⚠️ 2 spec hints

Spec Tezos:
- mutations should define a test(): send unrevealed, send revealed, send max (non delegating), delegate unrevealed, delegate revealed, undelegate unrevealed, undelegate revealed
- There are not enough accounts to cover all mutations. Please increase the account target to at least 8 accounts

Details of the 2 mutations

Spec Tezos (3)

Spec Tezos found 3 Tezos accounts (preload: 300ms). Will use TezosWallet 2.4.2 on nanoS 2.1.0
Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
necessary accounts resynced in 0.45ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
max spendable ~3.67835
★ using mutation 'send max (non delegating)'
→ TO Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox
✔️ transaction 
SEND MAX
TO tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA
with fees=0.000575
with gasLimit=701
with storageLimit=257
(estimatedFees 0.000949)
STATUS (954ms)
  amount: 3.614108 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 3.615057 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000949 XTZ",
+   "Fee": "0.000866 XTZ",
  }
(totally spent 3.5s – ends at 2023-09-28T08:24:02.217Z)
necessary accounts resynced in 0.39ms
▬ TezosWallet 2.4.2 on nanoS 2.1.0
→ FROM Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
max spendable ~1.67459
★ using mutation 'send max (non delegating)'
→ TO Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
✔️ transaction 
SEND MAX
TO tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF
with fees=0.000575
with gasLimit=701
with storageLimit=0
(estimatedFees 0.000949)
STATUS (735ms)
  amount: 1.674591 XTZ
  estimated fees: 0.000949 XTZ
  total spent: 1.67554 XTZ
errors: 
errors: 
⚠️ TEST deviceAction confirm step 'Fee'
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

  Object {
-   "Fee": "0.000949 XTZ",
+   "Fee": "0.000866 XTZ",
  }
(totally spent 3.7s – ends at 2023-09-28T08:24:02.221Z)

Details of the 6 uncovered mutations

Spec Tezos (6)

send unrevealed: balance is too low (1)
send revealed: balance is too low (1)
delegate unrevealed: balance is too low (1)
delegate revealed: balance is too low (1)
undelegate unrevealed: balance is too low (1)
undelegate revealed: balance is too low (1)

Portfolio ($3.49) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
Tezos (3)	150 ops , 5.35484 XTZ ($3.49)	👍 249	`tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF`

Tezos 1 cross: 3.6793 XTZ (149ops) (tz1aDK1uFAmnUXZ7KJPEmcCEFeYHiVZ56zVF on 44'/1729'/0'/0') tezbox#0 js:2:tezos:0240051fc51799e60dcc8870415b87fc4fd948e71b23fdc0d9b8ac7438cf7d4708:tezbox
Tezos 2: 1.67554 XTZ (1ops) (tz1he4fPXP3c9fFrztYT3k7KyYuLb28arFNn on 44'/1729'/1'/0') tezbox#1 js:2:tezos:02fe3d777af5380ef0a431c4985772c9669743050cee5feff717c3c3272d7a2810:tezbox
Tezos 3: 0 XTZ (0ops) (tz1SApkt3kmMaqNE1qtgADc6m3B49HZkFVDA on 44'/1729'/2'/0') tezbox#2 js:2:tezos:029d7bcf10737806147b22ba4578747ce4ac53e26b443c9eb1ac0e4d5bfbb8f67e:tezbox

Performance ⏲ 20.9s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	300ms	4.3s	1.17ms	1689ms	N/A	N/A	N/A	N/A
Tezos (2)	300ms	4.3s	1.17ms	1689ms	N/A	N/A	N/A	N/A

hedi-edelbloute

lgtm, unit test timeout but looks like flakiness as it is related to btc

github-actions · 2023-10-18T04:24:08Z

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

ghost · 2023-10-19T15:00:42Z

Already in develop, from #4879

hakim-adamik added 2 commits September 27, 2023 17:42

Remove old obsolete hack on Tezos gas limit

4ed2616

Add changeset

7e8e176

github-actions bot assigned ghost Sep 27, 2023

github-actions bot added the common Has changes in live-common label Sep 27, 2023

ghost marked this pull request as ready for review September 27, 2023 15:52

ghost self-requested a review as a code owner September 27, 2023 15:52

vercel bot deployed to Preview – ledger-live-docs September 28, 2023 07:52 View deployment

vercel bot deployed to Preview – live-common-tools September 28, 2023 07:53 View deployment

Update Tezos bot spec to expect ticker displayed with amounts

53d48e6

ghost force-pushed the bugfix/tezos-delegate-fees branch from 687fcc3 to 53d48e6 Compare September 28, 2023 08:11

vercel bot deployed to Preview – ledger-live-docs September 28, 2023 08:13 View deployment

vercel bot deployed to Preview – live-common-tools September 28, 2023 08:14 View deployment

hedi-edelbloute approved these changes Sep 28, 2023

View reviewed changes

ghost mentioned this pull request Sep 28, 2023

[bugfix] Remove old obsolete hack of Tezos gas limit (release) #4879

Merged

3 tasks

Merge remote-tracking branch 'ledger/develop' into HEAD

18fde15

vercel bot deployed to Preview – ledger-live-docs September 28, 2023 14:03 View deployment

vercel bot deployed to Preview – live-common-tools September 28, 2023 14:05 View deployment

Merge remote-tracking branch 'ledger/develop' into HEAD

06a5b59

vercel bot deployed to Preview – live-common-tools October 2, 2023 09:32 View deployment

vercel bot deployed to Preview – ledger-live-docs October 2, 2023 09:35 View deployment

github-actions bot added the Stale label Oct 18, 2023

ghost closed this Oct 19, 2023

ghost deleted the bugfix/tezos-delegate-fees branch October 19, 2023 15:00

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bugfix] Remove old obsolete hack of Tezos gas limit #4866

[bugfix] Remove old obsolete hack of Tezos gas limit #4866

ghost commented Sep 27, 2023 •

edited by ghost

Loading

changeset-bot bot commented Sep 27, 2023 •

edited

Loading

vercel bot commented Sep 27, 2023 •

edited

Loading

github-actions bot commented Sep 27, 2023

Spec Tezos (3)

Spec Tezos (5)

github-actions bot commented Sep 28, 2023

Spec Tezos (3)

Spec Tezos (6)

github-actions bot commented Sep 28, 2023

Spec Tezos (3)

Spec Tezos (5)

github-actions bot commented Sep 28, 2023

Spec Tezos (3)

Spec Tezos (6)

hedi-edelbloute left a comment

github-actions bot commented Oct 18, 2023

ghost commented Oct 19, 2023

[bugfix] Remove old obsolete hack of Tezos gas limit #4866

[bugfix] Remove old obsolete hack of Tezos gas limit #4866

Conversation

ghost commented Sep 27, 2023 • edited by ghost Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

changeset-bot bot commented Sep 27, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Sep 27, 2023 • edited Loading

github-actions bot commented Sep 27, 2023

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.51) ⏲ 19.8s

Spec Tezos (3)

Spec Tezos (5)

github-actions bot commented Sep 28, 2023

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.49) ⏲ 19.5s

Spec Tezos (3)

Spec Tezos (6)

github-actions bot commented Sep 28, 2023

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.51) ⏲ 21.3s

Spec Tezos (3)

Spec Tezos (5)

github-actions bot commented Sep 28, 2023

[Bot] Testing with 'Nitrogen' ❌ 2 txs ($3.49) ⏲ 20.9s

Spec Tezos (3)

Spec Tezos (6)

hedi-edelbloute left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2023

ghost commented Oct 19, 2023

ghost commented Sep 27, 2023 •

edited by ghost

Loading

changeset-bot bot commented Sep 27, 2023 •

edited

Loading

vercel bot commented Sep 27, 2023 •

edited

Loading