chore: bump monorepo to react 18 (react/types/dom) #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🦋 Changeset detectedLatest commit: fc121ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
desktop
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
df2ab9b to
b39e840
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
b39e840 to
0494a62
Compare
3 tasks
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
0494a62 to
dda35a7
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
dda35a7 to
1b47f0f
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
f8e62ae to
2e26897
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
2e26897 to
3e03736
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
3e03736 to
5590638
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
5590638 to
695f9a2
Compare
gre
reviewed
Oct 12, 2023
| ({ id: assetId }) => { | ||
| (t?: TokenCurrency | null) => { | ||
| // NOTE: to match the signature of AsaSelector, i had to change a bit the function | ||
| if (!t) return; |
There was a problem hiding this comment.
@haammar-ledger please confirm this looks good to you.
gre
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
lgtm from the code change perspective apart one logic change on blockchain that will just need a quick 👀 from this team.
- there will be some conflict resolution to make (sorry i did merge some pkg update my bad)
- only LLD tests really need to pass for this because all other projects are not impacted beside type changes (react 18 was already there except LLD)
valpinkman
force-pushed
the
support/react-18-everywhere
branch
2 times, most recently
from
d3b346f to
b01463b
Compare
valpinkman
force-pushed
the
support/react-18-everywhere
branch
from
b01463b to
fc121ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In an effort to harmonize react version accross all libraries and projects, we bumped all related libraries (react / react-dom / @types/react) everywhere where it was outdated.
Code impact on my part is very limited. Most of it were
typesto fix/to add.React 18 ships concurrent mode but it is not enabled by default, and I did not enable it (too much problem would arise with the number of outdated libraries we are using).
LLM was already using React 18 (only was using the wrong @types/react) and only LLD had to "migrate" from 17.
❓ Context
all✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.