LIVE-8169: multiversx coin modularization (#7750)

* create coin module package

* fix cosmos delegation flaky e2e test due to rounding error

* fix main.js file

---------

Co-authored-by: Alexandru Popenta <[email protected]>

.changeset/violet-planets-brake.md

@@ -0,0 +1,10 @@
+---
+"@ledgerhq/hw-app-elrond": patch
+"@ledgerhq/coin-elrond": patch
+"@actions/turbo-affected": patch
+"ledger-live-desktop": patch
+"live-mobile": patch
+"@ledgerhq/live-common": patch
+---
+
+Move Multiversx/Elrond to its own module

apps/ledger-live-desktop/src/renderer/families/elrond/AccountHeaderManageActions.ts

@@ -1,7 +1,7 @@
 import { useCallback, useMemo } from "react";
 import { useTranslation } from "react-i18next";
 import { useDispatch } from "react-redux";
-import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers/hasMinimumDelegableBalance";
+import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers";
 import { useElrondRandomizedValidators } from "@ledgerhq/live-common/families/elrond/react";
 import { openModal } from "~/renderer/actions/modals";
 import IconCoins from "~/renderer/icons/Coins";

apps/ledger-live-desktop/src/renderer/families/elrond/EarnRewards.tsx

@@ -4,8 +4,8 @@ import { Trans } from "react-i18next";
 import styled from "styled-components";
 import { BigNumber } from "bignumber.js";
 import { useElrondRandomizedValidators } from "@ledgerhq/live-common/families/elrond/react";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
-import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers/hasMinimumDelegableBalance";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
+import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers";
 import Text from "~/renderer/components/Text";
 import Button from "~/renderer/components/Button";
 import Box from "~/renderer/components/Box";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Delegations/components/Delegation/index.tsx

@@ -2,7 +2,7 @@ import React, { useMemo, Fragment, useCallback, ReactNode } from "react";
 import { BigNumber } from "bignumber.js";
 import { Trans } from "react-i18next";
 import { useDispatch } from "react-redux";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import Box from "~/renderer/components/Box/Box";
 import CheckCircle from "~/renderer/icons/CheckCircle";
 import ToolTip from "~/renderer/components/Tooltip";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Claim/fields/DelegationSelectorField.tsx

@@ -1,6 +1,6 @@
 import React, { useMemo, useCallback, useState, useEffect } from "react";
 import { BigNumber } from "bignumber.js";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import Box from "~/renderer/components/Box";
 import FirstLetterIcon from "~/renderer/components/FirstLetterIcon";
 import Label from "~/renderer/components/Label";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Claim/steps/StepClaimRewards.tsx

@@ -2,7 +2,7 @@ import React, { Fragment, useCallback } from "react";
 import { Trans } from "react-i18next";
 import { BigNumber } from "bignumber.js";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import invariant from "invariant";
 import TrackPage from "~/renderer/analytics/TrackPage";
 import Box from "~/renderer/components/Box";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Claim/steps/StepConfirmation.tsx

@@ -1,7 +1,7 @@
 import React from "react";
 import { Trans } from "react-i18next";
 import styled from "styled-components";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { SyncOneAccountOnMount } from "@ledgerhq/live-common/bridge/react/index";
 import TrackPage from "~/renderer/analytics/TrackPage";
 import Box from "~/renderer/components/Box";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Undelegate/fields/Validator.tsx

@@ -1,6 +1,6 @@
 import React, { useMemo, useState, useCallback } from "react";
 import { useTranslation } from "react-i18next";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import FirstLetterIcon from "~/renderer/components/FirstLetterIcon";
 import Box from "~/renderer/components/Box";
 import Label from "~/renderer/components/Label";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Undelegate/steps/Confirmation.tsx

@@ -1,7 +1,7 @@
 import React, { useCallback } from "react";
 import { useTranslation, Trans } from "react-i18next";
 import styled from "styled-components";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { SyncOneAccountOnMount } from "@ledgerhq/live-common/bridge/react/index";
 import TrackPage from "~/renderer/analytics/TrackPage";
 import Box from "~/renderer/components/Box";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Withdraw/fields/DelegationSelectorField.tsx

@@ -1,6 +1,6 @@
 import React, { useMemo, useCallback, useState, useEffect } from "react";
 import { BigNumber } from "bignumber.js";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import Box from "~/renderer/components/Box";
 import FirstLetterIcon from "~/renderer/components/FirstLetterIcon";
 import Label from "~/renderer/components/Label";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Withdraw/steps/StepConfirmation.tsx

@@ -1,7 +1,7 @@
 import React from "react";
 import { Trans } from "react-i18next";
 import styled from "styled-components";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { SyncOneAccountOnMount } from "@ledgerhq/live-common/bridge/react/index";
 import TrackPage from "~/renderer/analytics/TrackPage";
 import Box from "~/renderer/components/Box";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Modals/Withdraw/steps/StepWithdraw.tsx

@@ -1,5 +1,5 @@
 import React, { Fragment, useCallback } from "react";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
 import { Trans } from "react-i18next";
 import { BigNumber } from "bignumber.js";

apps/ledger-live-desktop/src/renderer/families/elrond/components/Unbondings/components/Unbonding/index.tsx

@@ -1,6 +1,6 @@
 import React, { useState, useCallback, useMemo, useEffect } from "react";
 import { Trans } from "react-i18next";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { useDispatch } from "react-redux";
 import Box from "~/renderer/components/Box/Box";
 import ExclamationCircleThin from "~/renderer/icons/ExclamationCircleThin";

apps/ledger-live-desktop/src/renderer/families/elrond/operationDetails.tsx

@@ -5,7 +5,7 @@ import {
   ELROND_EXPLORER_URL,
   ELROND_LEDGER_VALIDATOR_ADDRESS,
 } from "@ledgerhq/live-common/families/elrond/constants";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { useElrondPreloadData } from "@ledgerhq/live-common/families/elrond/react";
 import { ElrondProvider, ElrondOperation } from "@ledgerhq/live-common/families/elrond/types";
 import { Account, Operation } from "@ledgerhq/types-live";

apps/ledger-live-mobile/e2e/specs/delegate/cosmos.spec.ts

@@ -8,6 +8,7 @@ import {
 } from "../../models/currencies";
 import { Application } from "../../page";
 import DeviceAction from "../../models/DeviceAction";
+import BigNumber from "bignumber.js";
 
 let app: Application;
 let deviceAction: DeviceAction;
@@ -37,7 +38,12 @@ describe("Cosmos delegate flow", () => {
     const unit = getAccountUnit(testAccount);
 
     const usableAmount = testAccount.spendableBalance.minus(COSMOS_MIN_SAFE).minus(COSMOS_MIN_FEES);
-    const delegatedAmount = usableAmount.div(100 / delegatedPercent).integerValue();
+    // rounding to avoid floating point errors
+    // NOTE: we could allow for some precision error here to avoid rounding issues
+    const delegatedAmount = usableAmount
+      .multipliedBy(delegatedPercent)
+      .div(100)
+      .integerValue(BigNumber.ROUND_CEIL);
     const remainingAmount = usableAmount.minus(delegatedAmount);
 
     await app.stake.selectCurrency(testedCurrency);

apps/ledger-live-mobile/package.json

@@ -77,6 +77,7 @@
     "@formatjs/intl-pluralrules": "^5.0.0",
     "@formatjs/intl-relativetimeformat": "^11.1.8",
     "@ledgerhq/coin-cosmos": "workspace:^",
+    "@ledgerhq/coin-elrond": "workspace:^",
     "@ledgerhq/coin-evm": "workspace:^",
     "@ledgerhq/coin-framework": "workspace:^",
     "@ledgerhq/devices": "workspace:*",

apps/ledger-live-mobile/src/families/elrond/accountActions.tsx

@@ -1,16 +1,18 @@
-import React from "react";
+import {
+  hasMinimumDelegableBalance,
+  randomizeProviders,
+} from "@ledgerhq/live-common/families/elrond/helpers";
 import type { ElrondAccount } from "@ledgerhq/live-common/families/elrond/types";
-import { getCurrentElrondPreloadData } from "@ledgerhq/live-common/families/elrond/preload";
-import { randomizeProviders } from "@ledgerhq/live-common/families/elrond/helpers/randomizeProviders";
-import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers/hasMinimumDelegableBalance";
 import { IconsLegacy } from "@ledgerhq/native-ui";
+import React from "react";
 import { Trans } from "react-i18next";
 
 import type { Account } from "@ledgerhq/types-live";
 import type { ActionButtonEvent, NavigationParamsType } from "~/components/FabActions";
 
-import { NavigatorName, ScreenName } from "~/const";
+import { getCurrentElrondPreloadData } from "@ledgerhq/coin-elrond/preload";
 import { ParamListBase, RouteProp } from "@react-navigation/native";
+import { NavigatorName, ScreenName } from "~/const";
 
 /*
  * Declare the types for the properties and return payload.
@@ -39,6 +41,7 @@ const getMainActions = ({
    */
   const preloaded = getCurrentElrondPreloadData();
   const validators = randomizeProviders(preloaded.validators);
+
   const isFirstTimeFlow =
     account.elrondResources && account.elrondResources.delegations.length === 0;
   const screen = isFirstTimeFlow

apps/ledger-live-mobile/src/families/elrond/components/Body/Body.tsx

@@ -1,7 +1,7 @@
 import React, { useState, useEffect, useMemo, useCallback, FC } from "react";
 import { View } from "react-native";
 import { BigNumber } from "bignumber.js";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { useElrondRandomizedValidators } from "@ledgerhq/live-common/families/elrond/react";
 
 import type { ElrondProvider, ElrondAccount } from "@ledgerhq/live-common/families/elrond/types";

apps/ledger-live-mobile/src/families/elrond/components/Body/components/Delegations/Delegations.tsx

@@ -2,8 +2,8 @@ import React, { useCallback, useMemo } from "react";
 import { useNavigation } from "@react-navigation/native";
 import { useTranslation } from "react-i18next";
 import { View } from "react-native";
-import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers/hasMinimumDelegableBalance";
-import { getAccountCurrency, getMainAccount } from "@ledgerhq/live-common/account/index";
+import { hasMinimumDelegableBalance } from "@ledgerhq/live-common/families/elrond/helpers";
+import { getAccountCurrency, getMainAccount } from "@ledgerhq/coin-framework/account";
 import BigNumber from "bignumber.js";
 import type { StackNavigationProp } from "@react-navigation/stack";
 

apps/ledger-live-mobile/src/families/elrond/components/Body/components/Delegations/components/Delegation/Delegation.tsx

@@ -4,7 +4,7 @@ import { useTheme } from "@react-navigation/native";
 import { useTranslation } from "react-i18next";
 import { Text } from "@ledgerhq/native-ui";
 import { BigNumber } from "bignumber.js";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { ELROND_LEDGER_VALIDATOR_ADDRESS } from "@ledgerhq/live-common/families/elrond/constants";
 
 import CounterValue from "~/components/CounterValue";

apps/ledger-live-mobile/src/families/elrond/components/Body/components/Drawer/hooks/useDrawerItems.tsx

@@ -1,6 +1,6 @@
 import React, { useCallback, useMemo } from "react";
 import { useTranslation } from "react-i18next";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { Linking } from "react-native";
 import { getAddressExplorer, getDefaultExplorerView } from "@ledgerhq/live-common/explorers";
 

apps/ledger-live-mobile/src/families/elrond/components/Body/components/Rewards/Rewards.tsx

@@ -2,7 +2,7 @@ import React, { useCallback, useMemo } from "react";
 import { useNavigation } from "@react-navigation/native";
 import { View } from "react-native";
 import { useTranslation } from "react-i18next";
-import { getAccountCurrency, getMainAccount } from "@ledgerhq/live-common/account/index";
+import { getAccountCurrency, getMainAccount } from "@ledgerhq/coin-framework/account";
 import BigNumber from "bignumber.js";
 
 import type { StackNavigationProp } from "@react-navigation/stack";

apps/ledger-live-mobile/src/families/elrond/components/Body/components/Unbondings/Unbondings.tsx

@@ -1,7 +1,7 @@
 import React, { useMemo } from "react";
 import { useTranslation } from "react-i18next";
 import { View } from "react-native";
-import { getAccountCurrency, getMainAccount } from "@ledgerhq/live-common/account/index";
+import { getAccountCurrency, getMainAccount } from "@ledgerhq/coin-framework/account";
 
 import AccountSectionLabel from "~/components/AccountSectionLabel";
 import Unbonding from "./components/Unbonding";

apps/ledger-live-mobile/src/families/elrond/components/Body/components/Unbondings/components/Unbonding/Unbonding.tsx

@@ -2,7 +2,7 @@ import React, { useCallback } from "react";
 import { View, TouchableOpacity } from "react-native";
 import { useTheme } from "@react-navigation/native";
 import { Text } from "@ledgerhq/native-ui";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { useTranslation } from "react-i18next";
 import { BigNumber } from "bignumber.js";
 import { ELROND_LEDGER_VALIDATOR_ADDRESS } from "@ledgerhq/live-common/families/elrond/constants";

apps/ledger-live-mobile/src/families/elrond/components/Flows/Claim/components/PickMethod/PickMethod.tsx

@@ -4,8 +4,8 @@ import { useTheme } from "@react-navigation/native";
 import { Trans } from "react-i18next";
 import { BigNumber } from "bignumber.js";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { handleTransactionStatus } from "@ledgerhq/live-common/families/elrond/helpers/handleTransactionStatus";
-import { getMainAccount, getAccountCurrency } from "@ledgerhq/live-common/account/index";
+import { handleTransactionStatus } from "@ledgerhq/live-common/families/elrond/helpers";
+import { getAccountCurrency, getMainAccount } from "@ledgerhq/coin-framework/account";
 import useBridgeTransaction from "@ledgerhq/live-common/bridge/useBridgeTransaction";
 import { MIN_DELEGATION_AMOUNT } from "@ledgerhq/live-common/families/elrond/constants";
 

apps/ledger-live-mobile/src/families/elrond/components/Flows/Claim/components/PickValidator/PickValidator.tsx

@@ -2,7 +2,8 @@ import React, { useMemo, useCallback } from "react";
 import { View, FlatList } from "react-native";
 import { useTheme } from "@react-navigation/native";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { getMainAccount } from "@ledgerhq/live-common/account/index";
+import { getMainAccount } from "@ledgerhq/coin-framework/account";
+
 import BigNumber from "bignumber.js";
 import useBridgeTransaction from "@ledgerhq/live-common/bridge/useBridgeTransaction";
 

apps/ledger-live-mobile/src/families/elrond/components/Flows/Delegate/components/PickAmount/PickAmount.tsx

@@ -3,11 +3,10 @@ import { View, Keyboard, TouchableOpacity, TouchableWithoutFeedback, Platform }
 import { Trans } from "react-i18next";
 import { BigNumber } from "bignumber.js";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { formatCurrencyUnit } from "@ledgerhq/live-common/currencies/index";
 import { useTheme } from "styled-components/native";
 import { MIN_DELEGATION_AMOUNT } from "@ledgerhq/live-common/families/elrond/constants";
-import estimateMaxSpendable from "@ledgerhq/live-common/families/elrond/estimateMaxSpendable";
 
 import type { Transaction } from "@ledgerhq/live-common/families/elrond/types";
 import type { PickAmountPropsType, RatioType } from "./types";
@@ -47,7 +46,7 @@ const PickAmount = (props: PickAmountPropsType) => {
 
   const getMaxSpendable = useCallback(() => {
     const fetchMaxSpendable = async () => {
-      const amount = await estimateMaxSpendable({
+      const amount = await bridge.estimateMaxSpendable({
         account,
         transaction,
         parentAccount: undefined,
@@ -59,7 +58,7 @@ const PickAmount = (props: PickAmountPropsType) => {
     };
 
     fetchMaxSpendable();
-  }, [transaction, account]);
+  }, [bridge, account, transaction]);
 
   /*
    * Handle the ration selection callback.

apps/ledger-live-mobile/src/families/elrond/components/Flows/Delegate/components/SetDelegation/SetDelegation.tsx

@@ -3,10 +3,10 @@ import { Image, View, Animated } from "react-native";
 import { useTheme } from "@react-navigation/native";
 import { SafeAreaView } from "react-native-safe-area-context";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { handleTransactionStatus } from "@ledgerhq/live-common/families/elrond/helpers/handleTransactionStatus";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { handleTransactionStatus } from "@ledgerhq/live-common/families/elrond/helpers";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { getCurrencyColor } from "@ledgerhq/live-common/currencies/index";
-import { getAccountCurrency, getMainAccount } from "@ledgerhq/live-common/account/index";
+import { getAccountCurrency, getMainAccount } from "@ledgerhq/coin-framework/account";
 import { Text } from "@ledgerhq/native-ui";
 import { Trans } from "react-i18next";
 import useBridgeTransaction from "@ledgerhq/live-common/bridge/useBridgeTransaction";

apps/ledger-live-mobile/src/families/elrond/components/Flows/Delegate/components/ValidationSuccess/ValidationSuccess.tsx

@@ -3,7 +3,7 @@ import { View } from "react-native";
 import { useSelector } from "react-redux";
 import { Trans } from "react-i18next";
 import { useTheme } from "@react-navigation/native";
-import { getAccountCurrency } from "@ledgerhq/live-common/account/index";
+import { getAccountCurrency } from "@ledgerhq/coin-framework/account";
 
 import { accountScreenSelector } from "~/reducers/accounts";
 import { TrackScreen, track } from "~/analytics";

apps/ledger-live-mobile/src/families/elrond/components/Flows/Undelegate/components/PickAmount/PickAmount.tsx

@@ -3,7 +3,7 @@ import { View, Keyboard, TouchableOpacity, TouchableWithoutFeedback, Platform }
 import { Trans } from "react-i18next";
 import { BigNumber } from "bignumber.js";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { denominate } from "@ledgerhq/live-common/families/elrond/helpers/denominate";
+import { denominate } from "@ledgerhq/live-common/families/elrond/helpers";
 import { formatCurrencyUnit } from "@ledgerhq/live-common/currencies/index";
 import { useTheme } from "styled-components/native";
 import useBridgeTransaction from "@ledgerhq/live-common/bridge/useBridgeTransaction";

apps/ledger-live-mobile/src/families/elrond/components/Flows/Withdraw/components/WithdrawFunds/WithdrawFunds.tsx

@@ -2,9 +2,9 @@ import React, { useCallback, useMemo } from "react";
 import { View } from "react-native";
 import { Trans } from "react-i18next";
 import { useTheme } from "@react-navigation/native";
-import { handleTransactionStatus } from "@ledgerhq/live-common/families/elrond/helpers/handleTransactionStatus";
+import { handleTransactionStatus } from "@ledgerhq/live-common/families/elrond/helpers";
 import { getAccountBridge } from "@ledgerhq/live-common/bridge/index";
-import { getMainAccount, getAccountCurrency } from "@ledgerhq/live-common/account/index";
+import { getMainAccount, getAccountCurrency } from "@ledgerhq/coin-framework/account/helpers";
 import useBridgeTransaction from "@ledgerhq/live-common/bridge/useBridgeTransaction";
 
 import Button from "~/components/Button";

libs/coin-modules/coin-elrond/.eslintrc.js

@@ -0,0 +1,23 @@
+module.exports = {
+  env: {
+    browser: true,
+    es6: true,
+  },
+  rules: {
+    "no-console": ["error", { allow: ["warn", "error"] }],
+    "@typescript-eslint/no-empty-function": "off",
+    "@typescript-eslint/no-explicit-any": "warn",
+  },
+  overrides: [
+    {
+      files: ["src/test/**/*.{ts,tsx}"],
+      env: {
+        "jest/globals": true,
+      },
+      plugins: ["jest"],
+      rules: {
+        "no-console": "off",
+      },
+    },
+  ],
+};