Update MimbleWimble Coin and MimbleWimble Coin Floonet appFlags #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NicolasFlamel1, ty for your PR. Could you please rebase it ? An then I will merge it |
|
@tdejoigny-ledger I've rebased it. Thanks. |
tdejoigny-ledger
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Quarkslab's recommendations during their audit of the MimbleWimble Coin app, this PR is to resolve the
guidelines_enforcer.ymlCI failing during theCheck APP_LOAD_PARAMSstage for the MimbleWimble Coin app.APPLICATION_FLAG_LIBRARY(0x800) is not required by the app as of version 7.2.0 and has been removed from the Makefile.Don't merge this PR yet since Ledger's fork of the MimbleWimble Coin app is still on version 3.0.3