Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (context-module) [DSDK-586]: Implement transaction fields loader #513

Open
wants to merge 2 commits into
base: feature/dsdk-528-calldata-context-loader
Choose a base branch
from

Conversation

paoun-ledger
Copy link
Contributor

📝 Description

We need a context-module API to fetch the clear signing context of a single transaction field (transaction parameter typically).
Took the chance to migrate DOMAIN_NAME descriptors to TRUSTED_NAME which are the new backward-compatible version of names, supporting generic parser trusted names in addition to ENS domains.

❓ Context

  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@paoun-ledger paoun-ledger requested a review from a team as a code owner November 20, 2024 11:01
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 5:50pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 5:50pm

@paoun-ledger paoun-ledger changed the base branch from develop to feature/dsdk-528-calldata-context-loader November 20, 2024 11:01
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Messages
Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 211dbce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants