-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (context-module) [DSDK-586]: Implement transaction fields loader #513
Open
paoun-ledger
wants to merge
2
commits into
feature/dsdk-528-calldata-context-loader
Choose a base branch
from
feature/dsdk-586-transaction-field-context
base: feature/dsdk-528-calldata-context-loader
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
✨ (context-module) [DSDK-586]: Implement transaction fields loader #513
paoun-ledger
wants to merge
2
commits into
feature/dsdk-528-calldata-context-loader
from
feature/dsdk-586-transaction-field-context
+877
−339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
paoun-ledger
changed the base branch from
develop
to
feature/dsdk-528-calldata-context-loader
November 20, 2024 11:01
paoun-ledger
force-pushed
the
feature/dsdk-528-calldata-context-loader
branch
from
November 20, 2024 13:14
2119e80
to
282f536
Compare
paoun-ledger
force-pushed
the
feature/dsdk-586-transaction-field-context
branch
from
November 20, 2024 13:16
53c4a28
to
ae84b5b
Compare
aussedatlo
reviewed
Nov 26, 2024
paoun-ledger
force-pushed
the
feature/dsdk-586-transaction-field-context
branch
from
November 26, 2024 17:38
ae84b5b
to
ce0a01a
Compare
paoun-ledger
force-pushed
the
feature/dsdk-586-transaction-field-context
branch
from
November 26, 2024 17:48
ce0a01a
to
211dbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We need a context-module API to fetch the clear signing context of a single transaction field (transaction parameter typically).
Took the chance to migrate DOMAIN_NAME descriptors to TRUSTED_NAME which are the new backward-compatible version of names, supporting generic parser trusted names in addition to ENS domains.
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers