✨ (keyring-eth) [DSDK-430]: Add ProvideTransactionContextTask

[jiyuzhuang]

📝 Description

• Add ProvideTransactionContextTask;
• Add provideDomainNameTask method which will organise the ProvideDomainNameCommand;
• The commands below have been called in this task and they are been adjusted to have the same form:
  • SetPluginCommand (single command)
  • SetExternalPluginCommand (single command)
  • ProvideNFTInformationCommand (single command)
  • ProvideTokenInformationCommand (single command)
  • ProvideDomainNameCommand (mulpitle commands)
• Add new enum type ClearSignContextType in packages/signer/context-module/src/shared/model/ClearSignContext.ts to clarify the context type;
• The task will received hexadecimal string from the previous task and passes them into the commands / command organiser.

❓ Context

• JIRA or GitHub link: DSDK-430

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

• Covered by automatic tests.
• Impact of the changes:
  • Add ProvideTransactionContextTask.

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
device-sdk-ts-sample	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2024 10:37am

[github-actions]

	Messages
✅	Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 16b84b0

[aussedatlo]

LGTM 👍

[jdabbech-ledger]

[ask] if there is an error in any commands of this loop case, the error would be in the result.
Should this task continue in this case?

[aussedatlo]

I think if an error happen during a send of a provide, the task should stop, WDYT ?

[paoun-ledger]

I agree, I think in that case we should stop and return the error to upper layer so it can be forwarded to the user (for example the device auto-locked, or any other reason)

[jiyuzhuang]

👍