Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ (jfrog) [NO-ISSUE]: Push lib to jfrog artifactory #207

Closed
wants to merge 1 commit into from

Conversation

dedsxc
Copy link
Contributor

@dedsxc dedsxc commented Aug 20, 2024

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 1:21pm

Copy link
Contributor

github-actions bot commented Aug 20, 2024

Fails
🚫

Please fix the PR branch name to match the convention, see this documentation.

Wrong branch name: INFRAPRJ-6604

ℹ️ Regex to match: /^(feature|feat|bugfix|bug|hotfix|fix|support|chore|core|doc|refacto|refactor)\/((dsdk)-[0-9]+|no-issue)-.+/i

  • Rules:
    • Must start with a type (feature, bugfix, hotfix, support, chore, core, doc, refacto)
    • Followed by a SLASH ("/")
    • Followed by a JIRA issue number (DSDK-1234) or "no-issue"
    • Followed by a DASH ("-")
    • Followed by a description

ℹ️ Example: feat/dsdk-1234-my-feature

Generated by 🚫 dangerJS against 9b7d8b5

Copy link

vercel bot commented Sep 4, 2024

@AEnguerrand is attempting to deploy a commit to the LedgerHQ Team on Vercel.

To accomplish this, @AEnguerrand needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@dedsxc dedsxc force-pushed the INFRAPRJ-6604 branch 2 times, most recently from b512277 to 670ef13 Compare September 4, 2024 14:00
@dedsxc dedsxc force-pushed the INFRAPRJ-6604 branch 2 times, most recently from 0af6a43 to 4c4a248 Compare September 5, 2024 11:24
@dedsxc dedsxc changed the title ⚙️ (setup-jfrog) [INFRAPRJ-6604]: Push lib to jfrog artifactory ⚙️ (jfrog) [INFRAPRJ-6604]: Push lib to jfrog artifactory Sep 5, 2024
@dedsxc dedsxc changed the title ⚙️ (jfrog) [INFRAPRJ-6604]: Push lib to jfrog artifactory ⚙️ (jfrog) [NO-ISSUE]: Push lib to jfrog artifactory Sep 5, 2024
@dedsxc dedsxc closed this Sep 5, 2024
@dedsxc dedsxc deleted the INFRAPRJ-6604 branch September 5, 2024 13:33
@@ -9,8 +9,12 @@ env:

jobs:
publish:
environment: Production
runs-on: ubuntu-latest
# environment: Production
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ASK] can you reset the environment needed to production (we have special rules that require an approval from one of the team members to go through with production workflows)

@@ -1,7 +1,6 @@
{
"name": "@ledgerhq/device-sdk",
"version": "1.0.0",
"private": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SHOULD] please don't remove the private: true from the root package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants