-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚙️ (jfrog) [NO-ISSUE]: Push lib to jfrog artifactory #207
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AEnguerrand is attempting to deploy a commit to the LedgerHQ Team on Vercel. To accomplish this, @AEnguerrand needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
73ed9e0
to
f67c47b
Compare
b512277
to
670ef13
Compare
670ef13
to
95bb162
Compare
aa4e6dd
to
97ad0c4
Compare
97ad0c4
to
a2a5731
Compare
6d57c6d
to
3c367de
Compare
3c367de
to
f07ac20
Compare
9f5e890
to
f4469f8
Compare
f4469f8
to
6874816
Compare
6874816
to
fc0e5e7
Compare
0af6a43
to
4c4a248
Compare
4c4a248
to
f72b715
Compare
f72b715
to
6ed730a
Compare
6ed730a
to
f595762
Compare
f595762
to
12fdcfd
Compare
12fdcfd
to
007a694
Compare
007a694
to
fd1ab3e
Compare
fd1ab3e
to
9b7d8b5
Compare
5e39fd5
to
9b7d8b5
Compare
@@ -9,8 +9,12 @@ env: | |||
|
|||
jobs: | |||
publish: | |||
environment: Production | |||
runs-on: ubuntu-latest | |||
# environment: Production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ASK] can you reset the environment needed to production (we have special rules that require an approval from one of the team members to go through with production workflows)
@@ -1,7 +1,6 @@ | |||
{ | |||
"name": "@ledgerhq/device-sdk", | |||
"version": "1.0.0", | |||
"private": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SHOULD] please don't remove the private: true
from the root package.json
📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
🧐 Checklist for the PR Reviewers