B2CA-1558: Port Standard Makefile #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Standard-Makefile
branch
2 times, most recently
from
7dbca3a to
e288cad
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Standard-Makefile
branch
7 times, most recently
from
4d3253b to
65ff397
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Standard-Makefile
branch
2 times, most recently
from
427aa88 to
1c57070
Compare
- flare - flare_coston - goerli - ropsten
- No need to copy local files - No need to keep local copy of 'etherum-plugin-sdk' files - Select needed files directly from the Makefile
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Standard-Makefile
branch
3 times, most recently
from
96812fd to
de0df41
Compare
apaillier-ledger
requested changes
Apr 25, 2024
- Fix CodeQL warnings - Port lots of improvements/fixes from PR #225 - replace 'array_hexstr' and '%*H' format by sdk function 'format_hex' - Add 'noreturn' attribute in 'main.c'
- Fix default APPNAME typo (waiting VSCode fix to remove the init here) - Find dynamically ethereum-plugin-sdk src instead of add them manually - Typo/Syntax
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Standard-Makefile
branch
from
5e389b2 to
076077f
Compare
apaillier-ledger
approved these changes
Apr 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the Makefile, and few fixes in the code:
flareflare_costonropstengoerligit submodulefrom theMakefile(and adapt the documentation)ethereum-plugin-sdkauto committest_legacy_contract, and simplify associated testarray_hexstrand%*Hformat by sdk functionformat_hexnoreturnattribute inmain.cetherum-plugin-sdkfilesU2FsupportChanges include