Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bob #567

Closed
wants to merge 3 commits into from
Closed

feat: add bob #567

wants to merge 3 commits into from

Conversation

gregdhill
Copy link

Description

Added BOB mainnet chain id, see Chainlist.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Signed-off-by: Gregory Hill <[email protected]>
@vforgeoux-ledger
Copy link
Member

Hey @gregdhill , thanks for your PR ! It seems that we are missing your 64px icon in the glyphs folder though. You should find more informations here on how to craft one.

Note : The naming format for the glyphs icon will soon be updated on the developer portal, but it should now be chain_yourchainid_64px.gif

@vforgeoux-ledger
Copy link
Member

Hi @gregdhill , we want to merge the new networks PR today, so can you please have a look ?

Signed-off-by: Gregory Hill <[email protected]>
@gregdhill
Copy link
Author

@vforgeoux-ledger added the glyph icon now using the new format. Let me know if that will suffice.

@vforgeoux-ledger
Copy link
Member

vforgeoux-ledger commented Jun 24, 2024

@gregdhill It doesn't respect exactly the guidelines. I've crafted this one for you :
chain_60808_64px
Does it suit you ?

Signed-off-by: Gregory Hill <[email protected]>
@gregdhill
Copy link
Author

@vforgeoux-ledger assuming the logo should be square? I don't think that is mentioned explicitly in the guidelines. Uploaded a new version now, please check

@vforgeoux-ledger
Copy link
Member

I did the commit with one I crafted. Let me know if you really want the full black to replace it @gregdhill

@gregdhill
Copy link
Author

Ah no should be all black @vforgeoux-ledger but can you let us know what guideline we are still missing?

@vforgeoux-ledger
Copy link
Member

I just pushed on my branch the new one you sent. Your change respects the guidelines now (apart from the file naming)

@vforgeoux-ledger
Copy link
Member

Included in #598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants