-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bob #567
feat: add bob #567
Conversation
Signed-off-by: Gregory Hill <[email protected]>
Hey @gregdhill , thanks for your PR ! It seems that we are missing your 64px icon in the glyphs folder though. You should find more informations here on how to craft one. Note : The naming format for the glyphs icon will soon be updated on the developer portal, but it should now be |
Hi @gregdhill , we want to merge the new networks PR today, so can you please have a look ? |
Signed-off-by: Gregory Hill <[email protected]>
@vforgeoux-ledger added the glyph icon now using the new format. Let me know if that will suffice. |
@gregdhill It doesn't respect exactly the guidelines. I've crafted this one for you : |
Signed-off-by: Gregory Hill <[email protected]>
@vforgeoux-ledger assuming the logo should be square? I don't think that is mentioned explicitly in the guidelines. Uploaded a new version now, please check |
I did the commit with one I crafted. Let me know if you really want the full black to replace it @gregdhill |
Ah no should be all black @vforgeoux-ledger but can you let us know what guideline we are still missing? |
I just pushed on my branch the new one you sent. Your change respects the guidelines now (apart from the file naming) |
Included in #598 |
Description
Added BOB mainnet chain id, see Chainlist.
Changes include