Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2CA-1558: Port Ethereum on Flex #565

Merged
merged 28 commits into from
May 16, 2024
Merged

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Apr 8, 2024

Porting the App on Flex implies few intermediate steps. Here is what this PR includes:

  • Adapt tree to Flex, fixing compilation errors
  • Declare Flex in the manifest
  • Adding Flex dedicated icons (App and Clones)
  • Rename glyphs, removing stax prefix, because they are compatible with both Stax and Flex
  • Port nbgl_useCase_XXX new API:
    • nbgl_useCaseHomeAndSettings
    • nbgl_useCaseAddressReview
    • nbgl_useCaseReview
    • nbgl_useCaseGenericReview
    • nbgl_useCaseStreamingReview
  • Simplify the ragger test functions using scenario_navigator.review_approve and scenario_navigator.review_reject
  • Update few BAGL wording to avoid confusion during snapshot comparison (Change Sign to Review on 1st screen)
  • Adapt the python client:
    • Adapt the toggle_settings, because Flex has less widgets on each page
    • Add command for new test Perform Privacy Operation
    • Remove useless delay (speculos is no more slow with Stax)
  • Adapt the tests:
    • Check against Flex for test_get_address.py
    • Add tests for comand Perform Privacy Operation (can only run on device due to speculos limitation on curve ed25519)
    • Add test for comand Confirm Parameter Selector
  • Add Flex snapshots

Note: There is still a remaining point, which is a limitation for now: eip712 is quiete complex, and needs more work to be ported to the new nbgl_useCaseXXX API. Thus, the corresponding ragger tests are skipped for Flex.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Flex branch 6 times, most recently from 01d0855 to 325e5d7 Compare April 15, 2024 16:20
src_nbgl/ui_sign_message.c Fixed Show fixed Hide fixed
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Flex branch 15 times, most recently from 7d6d522 to 6cf5cdd Compare April 22, 2024 16:10
src_nbgl/ui_sign_message.c Fixed Show fixed Hide fixed
@tdejoigny-ledger
Copy link
Contributor

As part of Flex porting it could be good also to update this file in order to prepare the plugins flex porting

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Flex branch 3 times, most recently from 1c2eb25 to 12c9bbb Compare April 29, 2024 10:58
@cedelavergne-ledger cedelavergne-ledger marked this pull request as ready for review April 29, 2024 14:11
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Flex branch from 2b9fd72 to 6cfc7bf Compare May 7, 2024 14:24
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1558_Port-Flex branch from 6cfc7bf to c0d19fd Compare May 13, 2024 12:33
@cedelavergne-ledger cedelavergne-ledger merged commit e434173 into develop May 16, 2024
129 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1558_Port-Flex branch May 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants