-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B2CA-1558: Port Ethereum on Flex #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
6 times, most recently
from
April 15, 2024 16:20
01d0855
to
325e5d7
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
15 times, most recently
from
April 22, 2024 16:10
7d6d522
to
6cf5cdd
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
from
April 23, 2024 13:01
6cf5cdd
to
2e07df0
Compare
As part of Flex porting it could be good also to update this file in order to prepare the plugins flex porting |
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
3 times, most recently
from
April 29, 2024 10:58
1c2eb25
to
12c9bbb
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
from
April 29, 2024 14:15
12c9bbb
to
d5628d6
Compare
…nfirm_parameter_selector.c
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
from
May 7, 2024 14:24
2b9fd72
to
6cfc7bf
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1558_Port-Flex
branch
from
May 13, 2024 12:33
6cfc7bf
to
c0d19fd
Compare
apaillier-ledger
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the App on Flex implies few intermediate steps. Here is what this PR includes:
stax
prefix, because they are compatible with both Stax and Flexnbgl_useCase_XXX
new API:nbgl_useCaseHomeAndSettings
nbgl_useCaseAddressReview
nbgl_useCaseReview
nbgl_useCaseGenericReview
nbgl_useCaseStreamingReview
scenario_navigator.review_approve
andscenario_navigator.review_reject
toggle_settings
, because Flex has less widgets on each pagePerform Privacy Operation
test_get_address.py
Perform Privacy Operation
(can only run on device due to speculos limitation on curveed25519
)Confirm Parameter Selector
Note: There is still a remaining point, which is a limitation for now: eip712 is quiete complex, and needs more work to be ported to the new
nbgl_useCaseXXX
API. Thus, the corresponding ragger tests are skipped for Flex.Changes include