Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712 empty array handling fix #559

Merged
merged 8 commits into from
May 3, 2024
Merged

EIP-712 empty array handling fix #559

merged 8 commits into from
May 3, 2024

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Mar 27, 2024 •
edited
Loading

Description

  • Fix wrong signatures with empty array within nested structs
  • Now uses Web3.py to verify EIP-712 signatures in Ragger tests

Fixes LedgerHQ/ledger-live#6065

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger marked this pull request as draft March 27, 2024 17:52
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/eip712_empty_array_handling branch 4 times, most recently from ddc7f54 to daa3d61 Compare March 28, 2024 17:27
@apaillier-ledger apaillier-ledger marked this pull request as ready for review March 29, 2024 09:09
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/eip712_empty_array_handling branch from daa3d61 to e542173 Compare April 4, 2024 13:14
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/eip712_empty_array_handling branch 3 times, most recently from f73795e to f7280f5 Compare April 15, 2024 13:03
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/eip712_empty_array_handling branch from f7280f5 to faca50d Compare April 25, 2024 16:12
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/eip712_empty_array_handling branch from faca50d to e7e1927 Compare May 2, 2024 16:37
@apaillier-ledger apaillier-ledger merged commit 5e661fd into develop May 3, 2024
120 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/eip712_empty_array_handling branch May 3, 2024 11:15
@lambertkevin lambertkevin mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: signEIP712Message result error
2 participants
@apaillier-ledger @fbeutin-ledger