Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2CA-1247: Fix deprecated warnings #551

Merged
merged 10 commits into from
Mar 27, 2024
Merged

B2CA-1247: Fix deprecated warnings #551

merged 10 commits into from
Mar 27, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Mar 18, 2024 •
edited
Loading

This PR Adds the Guideline enforcer CI.

In order to have those workflows functionnal and 🟢, this PR also contains:

  • Fix the compilation warnings (like deprecated)
  • Fix scan-build issues
  • Fix mispelling and various linter errors
  • Adapt ci-workflow to reusable and guideline enforrcer
  • Fix glyphs and icons
  • Update version to 1.11.1

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch from 478fbc5 to effc895 Compare March 18, 2024 13:33
@cedelavergne-ledger cedelavergne-ledger mentioned this pull request Mar 18, 2024
Closed
6 tasks
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch 11 times, most recently from bfd83e2 to 7676309 Compare March 19, 2024 16:35
@cedelavergne-ledger cedelavergne-ledger changed the title B2CA-2147: Fix deprecated warnings B2CA-1147: Fix deprecated warnings Mar 20, 2024
@cedelavergne-ledger cedelavergne-ledger changed the title B2CA-1147: Fix deprecated warnings B2CA-1247: Fix deprecated warnings Mar 20, 2024
@cedelavergne-ledger cedelavergne-ledger mentioned this pull request Mar 20, 2024
Closed
6 tasks
fbeutin-ledger
fbeutin-ledger reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@fbeutin-ledger fbeutin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question, why remove .github/workflows/auto-author-assign.yml ?
(No opinion either way, just curious)

@cedelavergne-ledger
Copy link
Contributor Author

Small question, why remove .github/workflows/auto-author-assign.yml ? (No opinion either way, just curious)

Because just assigning the author to his own PR seems not usefull.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch from 7676309 to 0fa5e68 Compare March 25, 2024 13:34
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch 3 times, most recently from 5e513a0 to 81b142a Compare March 26, 2024 07:45
@cedelavergne-ledger cedelavergne-ledger mentioned this pull request Mar 26, 2024
Closed
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch from 81b142a to 243462f Compare March 26, 2024 10:31
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch 3 times, most recently from 11a0d2b to 70483e4 Compare March 26, 2024 14:20
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch 2 times, most recently from 09e6657 to f9b8242 Compare March 26, 2024 15:27
fbeutin-ledger
fbeutin-ledger previously approved these changes Mar 27, 2024
View reviewed changes
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1247_guideline-enforcer branch from f9b8242 to 83a2994 Compare March 27, 2024 13:43
@apaillier-ledger
Copy link
Contributor

apaillier-ledger commented Mar 27, 2024 •
edited
Loading

The plugin SDK changelog src_plugin_sdk/CHANGELOG.md needs to be updated.

@cedelavergne-ledger cedelavergne-ledger merged commit 2938964 into develop Mar 27, 2024
113 of 114 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/B2CA-1247_guideline-enforcer branch March 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xchapron-ledger xchapron-ledger xchapron-ledger left review comments

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

@apaillier-ledger apaillier-ledger Awaiting requested review from apaillier-ledger

Assignees

@cedelavergne-ledger cedelavergne-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cedelavergne-ledger @apaillier-ledger @fbeutin-ledger @xchapron-ledger