Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2CA-1522: Add sender field in transaction #545

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Mar 11, 2024

In addition to the To field, add the From to ease the transaction addresses reviews

Description

Add new field in the structure
Add new field in the ValuePair review information
Update tests and screenshots

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/add_sender_field branch 5 times, most recently from 6bcb4bc to 9cffc23 Compare March 13, 2024 07:29
@cedelavergne-ledger cedelavergne-ledger marked this pull request as ready for review March 13, 2024 07:58
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 14, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/add_sender_field branch 2 times, most recently from 171fd90 to 9da6b90 Compare March 28, 2024 14:10
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/add_sender_field branch 2 times, most recently from 7a68afb to bced8d6 Compare May 20, 2024 10:23
src/shared_context.h Outdated Show resolved Hide resolved
@apaillier-ledger apaillier-ledger force-pushed the cev/add_sender_field branch 2 times, most recently from f75e815 to 2b6a84f Compare June 19, 2024 16:25
@apaillier-ledger apaillier-ledger force-pushed the cev/add_sender_field branch 2 times, most recently from 11fcdcb to 59c21d7 Compare June 20, 2024 08:04
@apaillier-ledger apaillier-ledger self-requested a review June 20, 2024 08:06
@cedelavergne-ledger cedelavergne-ledger merged commit 6d6f7c7 into develop Jun 20, 2024
151 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/add_sender_field branch June 20, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants