Explicit unknown ticker #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
feat/apa/explicit_unknown_ticker
branch
3 times, most recently
from
9b3dfa1 to
6b512bc
Compare
apaillier-ledger
force-pushed
the
feat/apa/explicit_unknown_ticker
branch
from
6b512bc to
9ea5d42
Compare
tdejoigny-ledger
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now when displaying an amount of an unknown ticker, shows ??? as the ticker instead of always falling back to the app's native currency so that it does not lead the user into thinking he's spending something else.
The ticker fallback is kept for swap fees for retro-compatibility with the CAL (#534).
Changes include