Improve error-handling of chain ID when parsing APDUs #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
fix/apa/chain_id_check_for_clones
branch
2 times, most recently
from
dc78e10 to
d77baa0
Compare
apaillier-ledger
changed the title
apaillier-ledger
force-pushed
the
fix/apa/chain_id_check_for_clones
branch
3 times, most recently
from
63a0bef to
3d82bc7
Compare
src_features/provideErc20TokenInformation/cmd_provideTokenInfo.c
Outdated
Show resolved
Hide resolved
apaillier-ledger
force-pushed
the
fix/apa/chain_id_check_for_clones
branch
2 times, most recently
from
5370d04 to
9f77e01
Compare
fbeutin-ledger
previously approved these changes
Feb 5, 2024
apaillier-ledger
force-pushed
the
fix/apa/chain_id_check_for_clones
branch
from
9f77e01 to
91352af
Compare
fbeutin-ledger
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ever since the migration of Ethereum compatible networks into the Ethereum app, some commands were accepted (or refused) when they shouldn't have base on the given chain ID.
Changes include