Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix standard plugin variant + null-check on parameters #510

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix standard plugin variant + null-check on parameters #510

merged 3 commits into from
Dec 7, 2023

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Dec 7, 2023 •
edited
Loading

Description

  • Fixed variable name for the variant setting in the standard_plugin Makefile
  • Added a null-check in the dispatch_call function

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

fbeutin-ledger
fbeutin-ledger previously approved these changes Dec 7, 2023
View reviewed changes
@apaillier-ledger apaillier-ledger changed the title Fix standard plugin makefile improperly setting variant value Fix standard plugin variant + null-check on parameters Dec 7, 2023
@apaillier-ledger apaillier-ledger merged commit 97f17b2 into develop Dec 7, 2023
88 of 93 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/standard_plugin_variant branch December 7, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejoigny-ledger tdejoigny-ledger tdejoigny-ledger approved these changes

@fbeutin-ledger fbeutin-ledger fbeutin-ledger left review comments

Assignees

@apaillier-ledger apaillier-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apaillier-ledger @fbeutin-ledger @tdejoigny-ledger