Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Numbers Protocol to network #450

Closed
wants to merge 2 commits into from

Conversation

shc261392
Copy link

Description

Add Numbers Protocol to network.

Numbers Mainnet is on Chainlist.org. The SLIP-0044 update is also created.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@shc261392
Copy link
Author

64px GIF icon:
NUM_64px

32px GIF icon:
NUM_32px

@vforgeoux-ledger
Copy link
Member

Hello @shc261392 , can you please update your PR with latest guidelines ? So we can trigger the CI and see if the icons are fine. Thanks!

@shc261392
Copy link
Author

Hi @vforgeoux-ledger , I've updated the PR with the guideline and added the icon. Thanks!

@vforgeoux-ledger
Copy link
Member

Hi @vforgeoux-ledger , I've updated the PR with the guideline and added the icon. Thanks!

It looks like the Stax icon doesn't pass the CI. Can you please fix it ?
Let me know if this tool helps.

Signed-off-by: James Chien <[email protected]>
@shc261392
Copy link
Author

@vforgeoux-ledger I've replcaed the icon with the image generated via the tool you mentioned. Could you trigger the CI again and let's see if it passes?

@vforgeoux-ledger
Copy link
Member

@vforgeoux-ledger I've replcaed the icon with the image generated via the tool you mentioned. Could you trigger the CI again and let's see if it passes?

✅ , remaining failing checks are on our side. Thanks @shc261392

@vforgeoux-ledger vforgeoux-ledger mentioned this pull request Jan 2, 2024
6 tasks
@apaillier-ledger
Copy link
Contributor

Already added in #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants