Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typos #414

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
- [Running all tests](#running-all-tests)
- [With Makefile](#with-makefile)
- [With yarn](#with-yarn)
- [Running a specific tests](#running-a-specific-tests)
- [Running a specific test](#running-a-specific-tests)
- [Adding tests](#adding-tests)
- [Zemu](#zemu)
- [Update binaries](#update-binaries)
Expand Down Expand Up @@ -99,7 +99,7 @@ Testing is done via the open-source framework [zemu](https://github.com/Zondax/z
yarn test
```

### Running a specific tests
### Running a specific test

1. Go to the `tests` folder and run:
- ```sh
Expand Down Expand Up @@ -128,7 +128,7 @@ Finally make sure you adapt the expected signature!

#### Update binaries

Don't forget to update the binaries in the test folder. To do so, compile with those environement variables:
Don't forget to update the binaries in the test folder. To do so, compile with those environment variables:

```sh
make DEBUG=1 ALLOW_DATA=1
Expand All @@ -145,7 +145,7 @@ Repeat the operation for a binary compiled with nanoX SDK and change for `ethere

## Contributing

Contributions are what make the open source community such an amazing place to learn, inspire, and create. Any contributions you make are **greatly appreciated**.
Contributions are what makes the open source community such an amazing place to learn, inspire, and create. Any contributions you make are **greatly appreciated**.

If you have a suggestion that would make this better, please fork the repo and create a pull request. You can also simply open an issue with the tag `enhancement`.

Expand Down
4 changes: 2 additions & 2 deletions doc/eth_contract_support_embedded.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This document described how a specific device UI for a smart contract can be add

## Standard support

The applications already includes dedicated UI support for those specific contract calls :
The applications already include dedicated UI support for those specific contract calls :

* ERC 20 approve(address, uint256) - implementation in *src_features/erc20_approval*
* ERC 20 transfer(address, uint256) - implementation in *src_features/signTx*
Expand Down Expand Up @@ -46,7 +46,7 @@ The following online tool can be used to compute selectors https://emn178.github

## Sample implementation of a function call

This example describes how to implement a specific UI for a contract call. This exemple is using Starkex token deposit - *deposit(uint256 tokenId, uint256 vaultId, uint256 quantizedAmount)*
This example describes how to implement a specific UI for a contract call. This example is using Starkex token deposit - *deposit(uint256 tokenId, uint256 vaultId, uint256 quantizedAmount)*


* Implement the specific UI logic in a new *src_features* subdirectory - note that strings.common.maxFee will be provisioned with the maximum fee to pay for this call
Expand Down
2 changes: 1 addition & 1 deletion doc/eth_starkware_extensions.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Application version 1.5.0 - 4th of October 2020

## About

This specification describes the APDU messages interface implementing the Starkware extensions for the Ethereum appilcation
This specification describes the APDU messages interface implementing the Starkware extensions for the Ethereum application

## Modified general purpose APDUs

Expand Down
2 changes: 1 addition & 1 deletion doc/ethapp_plugins.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ Provide a sample callback mechanism for common plugin actions (amount to string,

Provide external plugins samples

Fully support Starkware as an independant application (APDU logic added)
Fully support Starkware as an independent application (APDU logic added)

Support extra flags for the generic UI (fast confirmation on first screen, ...)

Expand Down