Skip to content

Commit

Permalink
Add job checking the version bump
Browse files Browse the repository at this point in the history
  • Loading branch information
fbeutin-ledger committed Oct 30, 2023
1 parent a82b61f commit f96dbda
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 1 deletion.
43 changes: 43 additions & 0 deletions .github/workflows/python-client.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
name: Python client checks, package build and deployment

on:
Expand Down Expand Up @@ -35,6 +36,48 @@ jobs:
- name: Mypy type checking
run: (cd client && mypy src/)

get-develop-version:
name: Get develop version
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
outputs:
develop_version: ${{ steps.get-version.outputs.develop_version }}
steps:
- name: Check Out Code
uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.12.0
- name: Get version
id: get-version
env:
PYTHONPATH: client/src/ledger_app_clients
run: |
echo "develop_version=$(python -c 'from ethereum import __version__; print(__version__)')" >> $GITHUB_OUTPUT
version-check:
name: Check Version when opening a PR against develop
runs-on: ubuntu-latest
needs: get-develop-version
steps:
- name: Check Out Code
uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.12.0
- name: Check Version Bump
env:
DEVELOP_VERSION: ${{needs.get-develop-version.outputs.develop_version}}
PYTHONPATH: client/src/ledger_app_clients
run: |
current_version=$(python -c "from ethereum import __version__; print(__version__)")
if [[ "$current_version" == "$DEVELOP_VERSION" ]]; then
echo "Version in __init__.py hasn't been bumped. Please bump the version before merging."
exit 1
fi
packaging:
needs: [lint, mypy]
name: Build, test and deploy the Python package
Expand Down
6 changes: 6 additions & 0 deletions client/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.1.0] - 2023-30-10

### Added

- Update the ragger app client to support "set external plugin" APDU

## [0.0.1] - 2023-08-07

### Added
Expand Down
2 changes: 1 addition & 1 deletion client/src/ledger_app_clients/ethereum/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.0.1"
__version__ = "0.1.0"

0 comments on commit f96dbda

Please sign in to comment.