Merge pull request #646 from LedgerHQ/fix/apa/eip712_pairs_packing_ov…

…erflow EIP-712 pairs packing overflow fix on Stax
LedgerHQ · Sep 12, 2024 · 396f4ab · 396f4ab
2 parents 37aba62 + f5239b9
commit 396f4ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ethereum-plugin-sdk b/ethereum-plugin-sdk
diff --git a/src_nbgl/ui_sign_712.c b/src_nbgl/ui_sign_712.c
@@ -9,7 +9,7 @@
 #include "ui_message_signing.h"
 #include "ledger_assert.h"
 
-static nbgl_contentTagValue_t pairs[6];
+static nbgl_contentTagValue_t pairs[7];
 static nbgl_contentTagValueList_t pairs_list;
 static uint8_t pair_idx;
 static size_t buf_idx;
@@ -56,7 +56,7 @@ static void message_update(bool confirm) {
         buf_idx += buf_off;
         pair_idx += 1;
         pairs_list.nbPairs = nbgl_useCaseGetNbTagValuesInPage(pair_idx, &pairs_list, 0, &flag);
-        if (pairs_list.nbPairs < pair_idx) {
+        if ((pair_idx == ARRAYLEN(pairs)) || (pairs_list.nbPairs < pair_idx)) {
             nbgl_useCaseReviewStreamingContinue(&pairs_list, message_progress);
         } else {
             message_progress(true);
+44 −0		.github/workflows/publish_doc_website.yml
+2 −0		.gitignore
+3 −2		README.md
+ −		docs/img/Ledger-logo-696.webp
+51 −0		docs/index.md
+4 −0		docs/requirements.txt
+57 −0		docs/technical_informations/diagram.md
+15 −0		docs/technical_informations/globals.md
+11 −0		docs/technical_informations/handlers/handle_finalize.md
+11 −0		docs/technical_informations/handlers/handle_init_contract.md
+11 −0		docs/technical_informations/handlers/handle_provide_parameter.md
+19 −0		docs/technical_informations/handlers/handle_provide_token.md
+11 −0		docs/technical_informations/handlers/handle_query_contract_id.md
+19 −0		docs/technical_informations/handlers/handle_query_contract_ui.md
+10 −0		docs/technical_informations/handlers/index.md
+3 −0		docs/technical_informations/index.md
+5 −0		docs/technical_informations/tx_content.md
+3 −0		docs/technical_informations/utils/common_utils.md
+3 −0		docs/technical_informations/utils/index.md
+3 −0		docs/technical_informations/utils/plugin_utils.md
+1 −0		docs/test_framework/ci.md
+1 −0		docs/test_framework/fuzzing.md
+9 −0		docs/test_framework/index.md
+1 −0		docs/test_framework/ragger.md
+ −		docs/walkthrough/img/uniswap.webp
+52 −0		docs/walkthrough/index.md
+75 −0		mkdocs.yml
+2 −0		src/asset_info.h
+44 −12		src/common_utils.c
+212 −31		src/common_utils.h
+4 −2		src/eth_internals.h
+295 −57		src/eth_plugin_interface.h
+3 −10		src/main.c
+8 −5		src/plugin_utils.c
+81 −9		src/plugin_utils.h
+15 −3		src/tx_content.h