Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Syncer job tolerations + Adding Chart Lint - PR 148 #149

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix Syncer job tolerations + Adding Chart Lint - PR 148 #149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60139fc
Fix Syncer Tolerations
Jul 24, 2024
18a963d
Add chart lint to the workflows
Jul 24, 2024
68124f2
Add appVersion
Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/chart-lints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,7 @@ jobs:
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
if [[ -n "$changed" ]]; then
echo "changed=true" >> "$GITHUB_OUTPUT"
fi
fi
- name: Run chart-testing (lint)
if: steps.list-changed.outputs.changed == 'true'
run: ct lint --chart-dirs=charts --target-branch ${{ github.event.repository.default_branch }}
7 changes: 5 additions & 2 deletions charts/cloudstack-csi/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ apiVersion: v2
name: cloudstack-csi
description: A Helm chart for CloudStack CSI driver
type: application
version: 2.0.1
appVersion: 0.6.1
FarnazBGH marked this conversation as resolved.
Show resolved Hide resolved
version: 2.0.2
sources:
- https://github.com/Leaseweb/cloudstack-csi-driver
keywords:
- csi
- cloudStack
maintainers:
- name: hrak
- name: FarnazBGH
- name: lanord
2 changes: 1 addition & 1 deletion charts/cloudstack-csi/templates/syncer-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
securityContext: {{- toYaml .Values.syncer.podSecurityContext | nindent 8 }}
serviceAccountName: {{ .Values.syncer.serviceAccount.name }}
tolerations:
{{- with .Values.node.tolerations }}
{{- with .Values.syncer.tolerations }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.syncer.affinity }}
Expand Down
Loading