Fix idempotency and improve testability #225
hrakpr-check.yaml
on: pull_request
Lint
1m 21s
Test & Build
1m 13s
Annotations
12 errors and 2 warnings
|
Test & Build:
test/sanity/sanity_test.go#L49
undefined: driver.New
|
|
Test & Build
Process completed with exit code 2.
|
|
Lint:
pkg/driver/controller_test.go#L60
Comment should end in a period (godot)
|
|
Lint:
pkg/driver/controller_test.go#L102
avoid direct access to proto field actualRes.Volume, use actualRes.GetVolume() instead (protogetter)
|
|
Lint:
pkg/driver/controller_test.go#L103
avoid direct access to proto field actualRes.Volume.CapacityBytes, use actualRes.GetVolume().GetCapacityBytes() instead (protogetter)
|
|
Lint:
pkg/driver/controller_test.go#L104
avoid direct access to proto field actualRes.Volume.VolumeId, use actualRes.GetVolume().GetVolumeId() instead (protogetter)
|
|
Lint:
pkg/driver/controller_test.go#L105
avoid direct access to proto field actualRes.Volume.AccessibleTopology, use actualRes.GetVolume().GetAccessibleTopology() instead (protogetter)
|
|
Lint:
pkg/driver/controller_test.go#L106
avoid direct access to proto field actualRes.Volume.AccessibleTopology[0].GetSegments(), use actualRes.GetVolume().GetAccessibleTopology()[0].GetSegments() instead (protogetter)
|
|
Lint:
pkg/mount/mount.go#L216
unexported-return: exported method GetStatistics returns unexported type mount.volumeStatistics, which can be annoying to use (revive)
|
|
Lint:
pkg/driver/controller_test.go#L17
var-naming: var FakeDiskOfferingId should be FakeDiskOfferingID (revive)
|
|
Lint:
pkg/driver/identity.go#L28
ST1016: methods on the same type should have the same receiver name (seen 1x "d", 3x "cs") (stylecheck)
|
|
Lint:
pkg/driver/node_test.go#L43
require-error: for error assertions use require (testifylint)
|
|
Test & Build
Restore cache failed: Dependencies file is not found in /home/runner/work/cloudstack-csi-driver/cloudstack-csi-driver. Supported file pattern: go.sum
|
|
Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/cloudstack-csi-driver/cloudstack-csi-driver. Supported file pattern: go.sum
|