we were printing tx hash of half-built transactions, which was pointless #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrimalmadhur
previously approved these changes
Feb 13, 2024
samlaf
commented
Feb 14, 2024
shrimalmadhur
previously approved these changes
Feb 14, 2024
better tx hash log msg removed double logging remove main.go that was committed by mistake made WrapError public so we can reuse it in the codebase print txhash of failed txs for easier debugging removed redundant if statement
samlaf
force-pushed
the
fix-update-stakes-txhash-log-bug
branch
from
cf4ba6d to
1cad7ce
Compare
shrimalmadhur
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an example output from running avs-sync
Funnily enough, neither of the two txHash printed is the correct one, which was extremely confusing haha.
Changed it so that everywhere we only print txHash of txs that are successfully included in the chain.