Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Add getTotalSkill function to xi.crafting #6583

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

Flibe-XI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Add function to crafting_utils to get the total crafting skill + modifiers (gear, support). This will be useful for fishing quests.

Steps to test these changes

local skill = xi.crafting.getTotalSkill(player, xi.skill.GOLDSMITHING)
print(skill)
-- skill should be the players real crafting skill
!additem goldsmiths_apron
-- now it should be real skill + 1

@Flibe-XI Flibe-XI changed the title [Lua] Added getTotalSkill function to xi.crafting [Lua] Add getTotalSkill function to xi.crafting Dec 23, 2024
@zach2good zach2good merged commit d71c0ab into LandSandBoat:base Dec 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants