Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix textOffset for Magian Trial #1826 #6580

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix textOffset for Magian Trial #1826 #6580

merged 1 commit into from
Dec 23, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Dec 23, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Changes textOffset for magian trial 1826 to reflect the requirement of finishing blows with Final Heaven against beasts

Steps to test these changes

  1. !exec player:addItem(xi.item.SPHARAI, 1, 740, 5)
  2. Trade item to moogle
  3. Verify correct message as below

image

@claywar claywar merged commit 5780a90 into base Dec 23, 2024
14 checks passed
@claywar claywar deleted the bugfix/trial-1826 branch December 23, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants