Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNG seeding updates, update default RNG to MT64 #6565

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

WinterSolstice8
Copy link
Member

@WinterSolstice8 WinterSolstice8 commented Dec 20, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Improves RNG seeding with more secure methods
Switch to MT64 by default

Disables PCG32/64 due to imneme/pcg-cpp#94

This used to disable PCG32/64 but it turns out that's not a problem, the way we seed isn't effected

image

Steps to test these changes

compile, see RNG works with no errors

@WinterSolstice8 WinterSolstice8 changed the title RNG seeding updates, disable PCG32/64 due to bug RNG seeding updates, update default RNG to MT64 Dec 21, 2024
@zach2good zach2good merged commit e41fa00 into LandSandBoat:base Dec 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants