Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Adjust db::escapeString to emulate strlen #6523

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

WinterSolstice8
Copy link
Member

@WinterSolstice8 WinterSolstice8 commented Dec 13, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Apparently, escaped strings were making it in with garbage characters past a null terminator that the old code was not doing.
Partially solves #6518

Steps to test these changes

Change password, login, no problems

This makes it more in line with the old SqlConnection::EscapeString
@zach2good zach2good merged commit 18b6b24 into LandSandBoat:base Dec 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants