[BCNM] Add remaining WTB avatar BCNMs #6214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TracentEden
force-pushed
the
add_remaining_wtb_avatar_bcnms
branch
3 times, most recently
from
3c688a6 to
0245dd7
Compare
jmcmorris
reviewed
Sep 5, 2024
Comment on lines
29
to
51
| { | ||
| -- avatar | ||
| mobIds = | ||
| { | ||
| { cloisterOfFrostID.mob.SHIVA_PRIME_WTB }, | ||
| { cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 5 }, | ||
| { cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 10 }, | ||
| }, | ||
|
|
||
| allDeath = function(battlefield, mob) | ||
| -- when avatar defeated then all elementals should also die | ||
| for i = 1, 4 do | ||
| local elemental = GetMobByID(mob:getID() + i) | ||
| if elemental and elemental:isAlive() then | ||
| elemental:setHP(0) | ||
| end | ||
| end | ||
|
|
||
| battlefield:setStatus(xi.battlefield.status.WON) | ||
| end, | ||
| }, | ||
|
|
||
| { | ||
| -- elementals | ||
| mobIds = | ||
| { | ||
| { | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 1, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 2, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 3, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 4, | ||
| }, | ||
|
|
||
| { | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 6, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 7, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 8, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 9, | ||
| }, | ||
|
|
||
| { | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 11, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 12, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 13, | ||
| cloisterOfFrostID.mob.SHIVA_PRIME_WTB + 14, | ||
| }, | ||
| }, | ||
| }, | ||
| } |
There was a problem hiding this comment.
You should be able to use names rather than ids here. It should automatically figure out the stride for the mobs and which mobs belong to each battlefield area. I'd try it with one and test it. It should work. If it does work then you can simplify them all!
{
mobs = { "Shiva_Prime_WTB" }
allDeath = ...
},
{
mobs = { "Ice_Elemental" }
}
There was a problem hiding this comment.
You should be able to use names rather than ids here. It should automatically figure out the stride for the mobs and which mobs belong to each battlefield area. I'd try it with one and test it. It should work. If it does work then you can simplify them all!
{ mobs = { "Shiva_Prime_WTB" } allDeath = ... }, { mobs = { "Ice_Elemental" } }
Thanks, yep, this should now be fixed.
TracentEden
force-pushed
the
add_remaining_wtb_avatar_bcnms
branch
from
0245dd7 to
787b4a7
Compare
4 tasks
TracentEden
force-pushed
the
add_remaining_wtb_avatar_bcnms
branch
4 times, most recently
from
41f773d to
f7f5f3a
Compare
TracentEden
force-pushed
the
add_remaining_wtb_avatar_bcnms
branch
from
f7f5f3a to
2728316
Compare
3 tasks
TracentEden
force-pushed
the
add_remaining_wtb_avatar_bcnms
branch
2 times, most recently
from
22b6ae8 to
33fe209
Compare
Co-Authored-By: overefined <[email protected]> Co-Authored-By: dallano <[email protected]>
TracentEden
force-pushed
the
add_remaining_wtb_avatar_bcnms
branch
from
33fe209 to
b1bb2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This is a follow up PR of this PR (which only focused on Ifirit as an initial test case). This PR continues by implementing the remaining WTB avatar BCNMs (final fight and quest itself will come in future PRs).
The implementations are based on the captures by Siknoz and Aether (Levi here, here, here and here, Garuda here, here, here, here, here and here, Ramuh here and here, Shiva here and here, and Titan here and here). These captures give info like status immunities, TP moves, HPs, and so forth.
The main anomalies between the avatars are that Garuda does not use Pred Claws (in 100+ TP moves over 4 captures), while all other avatars do use their lvl 70 skills. Also fixes some small issues with the Ifrit fight that were missed previously, specifically that Ifrit does use Flaming Crush.
Also cloister of gales is missing the
ENTERING_THE_BATTLEFIELD_FORtext ID and this PR adds this so the correct text is shown when entering any cloister of gales BCNM.Steps to test these changes
Fight the (non-Ifrit) WTB avatar fights (use GM char to enter as the quest is not yet available)