Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Celadon Yggrete Shard pop NMs to Ceizak Battlegrounds #6209

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Yuchemey
Copy link
Contributor

@Yuchemey Yuchemey commented Sep 3, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

"It allows you to spawn the NMs (Notorious Monsters) Supernal Chapuli, Mastop, Unfettered Twitherym, Transcendent Scorpion, and Tax'et in Ceizak Battlegrounds."

Steps to test these changes

To achieve this, you need to trade the following items at specific locations in Ceizak Battlegrounds:

Celadon Yggrete Shard I to the ??? at J-7 for Unfettered Twitherym.
Celadon Yggrete Shard II to the ??? at J-9 for Supernal Chapuli.
Celadon Yggrete Shard III to the ??? at I-10 for Transcendent Scorpion.
Celadon Yggrete Shard IV to the ??? at G-8 for Mastop.
Celadon Yggrete Shard V to the Blank Space at G-10 for Tax'et.

@zach2good zach2good changed the title Ceizak_Battlegrounds PopNMs Add Celadon Yggrete Shard pop NMs to Ceizak Battlegrounds Sep 3, 2024
@zach2good
Copy link
Contributor

Hello and welcome! This all seems reasonable to me. We can squash the PR and rename the commit (like I did with the PR title) on the way in so it's a little more descriptive, or you can do it with a force push - whatever you prefer.

Does this make these NMs into loot pinatas? Or are they hooked up to any other system that means having them poppable but not yet balanced would be a bad thing?

@zach2good
Copy link
Contributor

There's some other stuff that needs to be added to these pops that looks like it'll be very easy to add that will mean these don't have to be revisited:

There's some additional messaging:
https://www.youtube.com/watch?v=eQw8711avqM
image

But no additional status effects like a level sync or anything, or confrontation, etc.

@zach2good
Copy link
Contributor

and then also, you get plasm in addition to XP, items, etc.

image

@Yuchemey
Copy link
Contributor Author

Yuchemey commented Sep 3, 2024

I thought of starting with pops. then everything that is important, like HP MP Level and the most important off all... their weapon skill i need to datmine in order to find 6 skills missing from them. then imma jump on Drops, Celadon drops. i will do one zone at a time.

@zach2good
Copy link
Contributor

Do you have access to retail? You can't typically look into the DATs for what animations are linked to which mobskills, etc. (which is why there are so many holes in mob_skills.sql)

@zach2good
Copy link
Contributor

(as long as they're not dropping loot, or letting people cheese anything, these are harmless to go in pretty much as they are)

@Yuchemey
Copy link
Contributor Author

Yuchemey commented Sep 3, 2024

I will put drops at the end when everything is all good and ready. I have access to retail.

@zach2good
Copy link
Contributor

I will put drops at the end when everything is all good and ready.

This is a sane way to handle this, thanks!

For mobskills, you'll need to get captures of the mobs doing the moves you're interested in. Here's a link to the capture discord, which should have instructions for how to get set up to do captures: https://discord.gg/4WsCZf5g

@Yuchemey
Copy link
Contributor Author

Yuchemey commented Sep 3, 2024

Thanks.

Copy link
Contributor

@claywar claywar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really excited to see people taking an interest in post-75 content. That being said, the pop messages are something that needs to be researched, and also seeing that warning makes me wonder if there's a confrontation effect that's not being displayed. Any time content level is displayed, my spidey-sense says there's something else going on.

@Yuchemey
Copy link
Contributor Author

Yuchemey commented Sep 4, 2024 via email

@Yuchemey
Copy link
Contributor Author

Yuchemey commented Sep 6, 2024

I'm really excited to see people taking an interest in post-75 content. That being said, the pop messages are something that needs to be researched, and also seeing that warning makes me wonder if there's a confrontation effect that's not being displayed. Any time content level is displayed, my spidey-sense says there's something else going on.

there are 2 ways you get this message. By trigger you get 2 message. "You have a sense that you need to trade <item_name>" and "The Level of difficulty is level 110116". And you get "The Level of difficulty is level 110116" By trading item.

I was thinking of making
Popping - PR
Mobskill HP/MP/Level - PR
Then Weakness - PR
Drops + Display Message - PR
then Ceizak is done

@claywar claywar merged commit 27d2498 into LandSandBoat:base Sep 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants