-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Speed] Adjustments to calculations and modifiers #6207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
from
September 3, 2024 11:52
b17166f
to
cd67b9f
Compare
Xaver-DaRed
added
the
core
Gives visibility for reviewers for impacted areas involving cpp
label
Sep 3, 2024
Co-authored-by: cocosolos <[email protected]>
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
from
September 3, 2024 14:45
cd67b9f
to
eaf7833
Compare
EpicTaru
suggested changes
Sep 3, 2024
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
from
September 3, 2024 18:46
30c52e3
to
b3fd755
Compare
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
2 times, most recently
from
September 4, 2024 16:02
412e0b4
to
a5e84e6
Compare
cocosolos
reviewed
Sep 4, 2024
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
from
September 5, 2024 11:10
a5e84e6
to
b0c88fc
Compare
WinterSolstice8
approved these changes
Sep 5, 2024
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
4 times, most recently
from
September 6, 2024 15:11
946e35b
to
80f1f22
Compare
cocosolos
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
EpicTaru
approved these changes
Sep 6, 2024
Small mistake on my part, Bolter's roll actually goes between cheer and gear. Otherwise everything else looks right. |
Co-authored-by: cocosolos <[email protected]>
Xaver-DaRed
force-pushed
the
speedy-gonzalez
branch
from
September 10, 2024 05:46
80f1f22
to
328cb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Uses info gathered by
COCONUTSCocosolos to adjust speed calculations.In short, gear that boosts your speed was unafected, flee is its own multiplier now and gear with penalties + quickening/mazurka are added before the multipliers are applied
Steps to test these changes
Just use gear and speed-altering stuff while walking