Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Speed] Adjustments to calculations and modifiers #6207

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented Sep 3, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Uses info gathered by COCONUTS Cocosolos to adjust speed calculations.

  • Makes gear penalties and mazurka/quickening additive to base speed, pre-multipliers
  • Adjusts additive modifiers to use a flat number to easily add to base speed.
  • Discovered a ridiculously small cap for mazurka and quickening combined, meaning they are indeed additive among them.

In short, gear that boosts your speed was unafected, flee is its own multiplier now and gear with penalties + quickening/mazurka are added before the multipliers are applied

Steps to test these changes

Just use gear and speed-altering stuff while walking

@Xaver-DaRed Xaver-DaRed added the core Gives visibility for reviewers for impacted areas involving cpp label Sep 3, 2024
@Xaver-DaRed Xaver-DaRed added the hold On hold, pending further action/info label Sep 3, 2024
scripts/enum/mod.lua Outdated Show resolved Hide resolved
src/map/modifier.h Outdated Show resolved Hide resolved
@Xaver-DaRed Xaver-DaRed removed the hold On hold, pending further action/info label Sep 3, 2024
@Xaver-DaRed Xaver-DaRed force-pushed the speedy-gonzalez branch 2 times, most recently from 412e0b4 to a5e84e6 Compare September 4, 2024 16:02
@Xaver-DaRed Xaver-DaRed force-pushed the speedy-gonzalez branch 4 times, most recently from 946e35b to 80f1f22 Compare September 6, 2024 15:11
Copy link
Contributor

@cocosolos cocosolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cocosolos
Copy link
Contributor

Small mistake on my part, Bolter's roll actually goes between cheer and gear. Otherwise everything else looks right.

@claywar claywar merged commit 8527243 into LandSandBoat:base Sep 13, 2024
12 checks passed
@Xaver-DaRed Xaver-DaRed deleted the speedy-gonzalez branch September 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Gives visibility for reviewers for impacted areas involving cpp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants