Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLS] Add NPC Entity Type, annotate NPC scripts, correct issues identified #6202

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Sep 1, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds TNpcEntity type definition
  • Annotates NPC scripts in all zones
  • Fixes errors in all NPC scripts identified by LLS
  • Adds missing entries and errant overloads to CBaseEntity and CTradeContainer definitions

Steps to test these changes

No impact to gameplay should occur, CI passing

@claywar claywar changed the title Lls/npcentity [LLS] Add NPC Entity Type, annotate NPC scripts, correct issues identified Sep 1, 2024
@claywar claywar merged commit c0ea86d into base Sep 2, 2024
13 checks passed
@claywar claywar deleted the lls/npcentity branch September 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants