Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lls] Annotate npcUtil global, correct issues identified #6201

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Sep 1, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds Lua Language Server annotations to npcUtil functions and corrects issues identified from them
  • Adds additional item enum entries

Steps to test these changes

CI should pass, quests should function normally along with no other impact to gameplay

@claywar claywar merged commit c57f162 into base Sep 1, 2024
12 checks passed
@claywar claywar deleted the lls/npcutil branch September 1, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants