Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] Audit spells elements and skills #6193

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented Aug 30, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Audits all spells elements and skills, based on wiki and dat info
  • Uses sql enums to define them, instead of numbers

Note: At some point I just stoped taking notes of ALL changes. This are the most important

Changes to elements:

  • All bar-spells from "Light" to their proper element (Inconsequential)
  • All teleport-like spells from "Wind" to "Light" (Inconsequential)
  • Meteor from "Light" to "None"
  • Meteor II from "Dark" to "Light"
  • Threnody II spells corrected.
  • Many random corrections
    • Uncle Teo Xaver story time: Once upon a time in the DSP era, we used a different (Read: Wrong) elemental order. That got fixed, however, seemingly, many spells were still using the old one here. There are quite a few and I didnt keep track of all of the ones I changed.

Changes to skills:

  • Gravity II from "Elemental" to "Enfeebling"
  • Comet from "Dark" to "Elemental"
  • Meteor II from "Dark" to "Elemental"
  • Added skills to certain spells that didnt have one set when they should.

Steps to test these changes

Import the table?
Did it import? You are done.

@LandSandBoat LandSandBoat deleted a comment from github-actions bot Aug 30, 2024
@Xaver-DaRed Xaver-DaRed force-pushed the sql-enums branch 2 times, most recently from c5ff034 to e204051 Compare August 30, 2024 21:56
@Xaver-DaRed Xaver-DaRed marked this pull request as ready for review August 30, 2024 23:33
@claywar claywar merged commit d5c52ff into LandSandBoat:base Aug 31, 2024
12 checks passed
@Xaver-DaRed Xaver-DaRed deleted the sql-enums branch September 2, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants