Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relic ws add effect durations #6191

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adjusts relic WS add effect durations to 120s (note: currently no proof for Randgrith's add effect but what was there was almost certainly more wrong. I don't see why it would't be 120s like the rest.

Commits have proof where available (all but Randgrith)

Apparently Onslaught's acc down was too low as well.

Steps to test these changes

Use WS, see longer add effect durations if they land, etc

accuracy down -> -30 acc
duration -> 120s
https://wiki.ffo.jp/html/3086.html ->
`追加効果:命中率ダウンの効果は命中-30。効果時間120秒`
@claywar claywar merged commit 6f36aee into LandSandBoat:base Aug 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants