[core] Force crit fail on synth if player zones for any reason #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterSolstice8
force-pushed
the
zoning_synth_stuff
branch
from
8cd103c to
dfd85ad
Compare
Xaver-DaRed
approved these changes
Aug 30, 2024
zach2good
reviewed
Aug 30, 2024
| @@ -485,6 +485,22 @@ void CZoneEntities::DecreaseZoneCounter(CCharEntity* PChar) | |||
| } | |||
| } | |||
|
|
|||
| // Duplicated from charUtils, it is theoretically possible through d/c magic to hit this block and not sendToZone | |||
There was a problem hiding this comment.
Just to be anal, can this be extracted out into something in charutils or synthutils? failSynthOnZone or something
WinterSolstice8
force-pushed
the
zoning_synth_stuff
branch
from
dfd85ad to
8e41ae8
Compare
zach2good
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Force crit fail on synth if player zones for any reason
Steps to test these changes
!zone after starting synth and crit fail