Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLS] Add core global definitions (luautils), clarify enums, and correct issues #6173

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Aug 26, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds luautils defintions for global functions accessible on the Lua side
  • Renames enums defined to use the same explicit name as position in xi table (zone enum == xi.zone)
  • Corrects issues identified by LLS from the above changes

Steps to test these changes

No impact to gameplay should be observed, CI should pass

@claywar
Copy link
Contributor Author

claywar commented Aug 27, 2024

Not sure whats going on with the Full Startup Windows check. Not throwing any errors up when testing locally on Windows, and seems is getting a nil return from a luautils binding (which shouldn't be possible)

@claywar
Copy link
Contributor Author

claywar commented Aug 27, 2024

Aha! so when the --load_all parameter is used with xi_map, everything is cached, including spec files. Latest commit adds a chunk to ignore items in that directory in this CI case

@claywar claywar merged commit f6433d0 into base Aug 27, 2024
12 checks passed
@claywar claywar deleted the lls/globals branch August 27, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants