Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua][chore] Equipment.lua clean up #5874

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

UmeboshiXI
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Replaces item IDs with item enum names.
Adds missing items to item enum lua.
Fixes BRAVURA_119_III enum using incorrect item ID.

NOTE: I noticed when swapping out the Item IDs that Homam legs are included in the artifact range? I have not looked into this further at this time on how this table is used exactly. Left a note in place.

image

Steps to test these changes

Item Enum should match Item ID. No changes should be noted from existing enum usage aside from BRAVURA_119_III which was incorrect.

@UmeboshiXI UmeboshiXI force-pushed the equipment_lua_cleanup branch from 95dd411 to a3b0688 Compare June 1, 2024 22:43
{ 15002, 15004 }, -- WotG Hand
{ 15746, 15748 }, -- WotG Feet
{ 15659, 15661 }, -- WotG Legs
{ xi.item.FIGHTERS_MASK, xi.item.EVOKERS_HORN }, -- Original Head
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get these are only ranges, but could you stylize this a bit to align beginning and end for the rows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted

@UmeboshiXI UmeboshiXI force-pushed the equipment_lua_cleanup branch from a3b0688 to b872b0d Compare June 2, 2024 00:01
@claywar claywar merged commit 65cc787 into LandSandBoat:base Jun 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants