Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction - Battlefields: Ghelsba Outpost, Ru'Hmet, Full Moon Fountain, Boneyard Gully #5871

Merged
merged 12 commits into from
Jun 1, 2024
Merged

Interaction - Battlefields: Ghelsba Outpost, Ru'Hmet, Full Moon Fountain, Boneyard Gully #5871

merged 12 commits into from
Jun 1, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Jun 1, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts and applies fixes to the following battlefields:

  • Save the Children
  • The Holy Crest
  • Wings of Fury
  • Petrifying Pair
  • Toadal Recall
  • When Angels Fall
  • The Moonlit Path
  • Moon Reading (Aijido now assists in battle)
  • Head Wind
  • Like the Wind
  • Shell We Dance?
  • A Sheep in Antlion's Clothing

Steps to test these changes

Enter/win/lose/exit all of the battlefields

Xaver-DaRed
Xaver-DaRed reviewed Jun 1, 2024
View reviewed changes
sql/npc_list.sql Outdated Show resolved Hide resolved
@claywar
Interaction - Battlefield: Sheep in Antlion's Clothing
1ac95b4 
Remove unused variables

Fix Ghelsba Outpost Armoury Crate definitions

Add superlink to when angels fall

Fix Moon Reading phase 2 coordinates

Remove BST pet from required mobs in Head Wind

Fix armoury crates, invalid mob spawn function

Fix errant change
@claywar claywar force-pushed the interaction/battlefields branch from d5d35fd to 1ac95b4 Compare June 1, 2024 14:11
@claywar claywar merged commit 651bb5b into base Jun 1, 2024
11 checks passed
@claywar claywar deleted the interaction/battlefields branch June 1, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xaver-DaRed Xaver-DaRed Xaver-DaRed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claywar @Xaver-DaRed