Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Fix Bastok Markets NPC data #5859

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 31, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes incorrect data for an NPC in Bastok Markets.

  • Removes duplicated speed value, which shifted data.
  • Adds missing entity flags

image

Steps to test these changes

  1. !pos -261.242 -12.36 80.643 235
  2. NPC should be hidden

Copy link
Contributor

@Xaver-DaRed Xaver-DaRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSERT INTO `npc_list` VALUES (17739777,'NPC[1]','NPC',171,-261.242,-12.136,80.643,0,50,50,0,0,0,6,27,0x0000620000000000000000000000000000000000,32,NULL,0);

This is th correct data that should be put in there.

@ampitere ampitere force-pushed the fix_hide_npc_flying_in_bastok_markets branch from dbac3d3 to 6d51f9e Compare May 31, 2024 00:39
@Xaver-DaRed Xaver-DaRed changed the title [SQL] Hide NPC flying in Bastok Markets [SQL] Fix Bastok Markets NPC data May 31, 2024
@claywar claywar merged commit af359d6 into LandSandBoat:base May 31, 2024
11 checks passed
@ampitere ampitere deleted the fix_hide_npc_flying_in_bastok_markets branch May 31, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants