Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quest]RDM AF3 Peace Spirit Conv #5846

Closed
wants to merge 1 commit into from

Conversation

hooksta4
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Converts RDM AF3 quest to IF.

  • Removes all NPC lua dialog associated with quest
  • Adds defaultActions for those NPC's
  • Reworked dialogs for Guardian Statue based on capture
    • Players can pop NM, zone and repop NM allowing for others to get the Nail Puller. Until the player on quest trades the Nail Puller to the box, they can do this indefinitely. https://ffxiclopedia.fandom.com/wiki/Talk:Peace_for_the_Spirit
    • TODO Verify If you get the message "Something feels wrong, but nothing happens.", click off Sneak.
    • This message shows if clicking on the box if the NM is alive.
    • Set localVar to only allow player to pop once per zone.

Steps to test these changes

Complete AF2 quest and speak with Curilla.
Follow questline.

@Frankie-hz
Copy link
Contributor

All AF quest conversions have been working on HXI since implementation with no issues/reports.

@hooksta4
Copy link
Contributor Author

hooksta4 commented Aug 12, 2024

Can we re run the Full startup check? Is there anything else I can do to get the Big Red X removed so someone reviews it? I added something and it ran fine this time ;)

[Quest]RDM AF3 Peace Spirit Conv

[Quest]RDM AF3 Peace Spirit Conv

[Quest]RDM AF3 Peace Spirit Conv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants