Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed areas to battlefields, workaround position update 0x05C #5837

Merged
merged 1 commit into from
May 28, 2024

Conversation

claywar
Copy link
Contributor

@claywar claywar commented May 27, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds ability to restrict a BCNM implementation to specific battlefield areas allowedAreas is a table of bools, keyed by the battlefield area ID, so allowedAreas = set{ 1, 3 } will restrict to only areas 1 and 3
  • Adds workaround for position update requests from battlefield framework if an area is unavailable

Steps to test these changes

Change allowedAreas to set{ 4 } so that all will be denied for one area, and also check back and forth between valid options.

@claywar claywar merged commit 913825e into base May 28, 2024
12 checks passed
@claywar claywar deleted the battlefield-restriction branch May 28, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants