Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Promyvion] Rework receptacles, stray agro and handle decorations #5766

Merged
merged 2 commits into from
May 18, 2024

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented May 17, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Shift-proofs promyvion zones completely.
  • Makes strays pop both with receptacle idle and engaged.
  • Makes strays agro/link dependant on their spawn (receptacle idle or engaged)
  • Corrects receptacle animations when poping strays.
  • Makes receptacle despawn faster than regular mobs.
  • Makes decorations on top of receptacles pop/depop based on receptacle status.

Close #5740
Close #5739

Steps to test these changes

Clear all 4 promyvions

To review:

  • Ignore all changes except the ones in promyvion.lua. They are just setup.
  • Review promyvion.lua as is. The git comparation just makes it harder.

@Xaver-DaRed Xaver-DaRed force-pushed the promyvion-part_2 branch 2 times, most recently from 6712c77 to de69f95 Compare May 17, 2024 17:24
@Xaver-DaRed Xaver-DaRed marked this pull request as ready for review May 17, 2024 19:10
@Xaver-DaRed
Copy link
Contributor Author

Tested all 4 promyvions twice and was able to properly complete them, trigger events, teleport, spawn strays and agro them properly.

Ready for review.

NOTE: There's still some work to do, regarding empty mobs elements. That's work for another time.

@claywar claywar merged commit d388dea into LandSandBoat:base May 18, 2024
11 checks passed
@Xaver-DaRed Xaver-DaRed deleted the promyvion-part_2 branch June 11, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Promy] Memory Receptacle throwing error on death causing the event not to trigger
2 participants