Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP] Refactor IsRateLimitedPacket method to use milliseconds #5761

Merged

Conversation

ampitere
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Updates PacketGuard.IsRateLimitedPacket to use milliseconds instead of seconds. Allows rate limiting to use fractions of a second. Resolves #430

Steps to test these changes

  1. Login
  2. Do some stuff
  3. ???
  4. Things don't break

@ampitere ampitere force-pushed the refactor_rate_limit_to_use_milliseconds branch from e6e83f7 to 20ec7a7 Compare May 17, 2024 00:45
@zach2good
Copy link
Contributor

With this change, don't you also need to change the tikmintw) timings 20 or so lines above? Otherwise they're now rate limited to 2ms...

@ampitere ampitere force-pushed the refactor_rate_limit_to_use_milliseconds branch from 20ec7a7 to 501d656 Compare May 17, 2024 01:15
@ampitere
Copy link
Contributor Author

With this change, don't you also need to change the tikmintw) timings 20 or so lines above? Otherwise they're now rate limited to 2ms...

Definitely needs to be updated for those yep, spamming jump looks pretty silly at 2.

@claywar claywar merged commit 5b9fca5 into LandSandBoat:base May 17, 2024
11 checks passed
@ampitere ampitere deleted the refactor_rate_limit_to_use_milliseconds branch May 17, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PacketGuard should handle rate-limiting in milliseconds, not seconds
4 participants