Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPP] Fix mob pets don't engage with master when summoned #5751

Merged

Conversation

ampitere
Copy link
Contributor

@ampitere ampitere commented May 16, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Currently when a mob summons a pet it doesn't not engage with their current target. This small change from id to targid makes them engage properly after being summoned.

Steps to test these changes

  1. !pos 88 -7 -13 185 (Dynamis - San d'Oria DRG NM spawn)
  2. !exec target:useMobAbility(732)
  3. Wyvern should attack you if the NM is

@ampitere ampitere changed the title [CPP] Fix pets don't engage with master when summoned [CPP] Fix mob pets don't engage with master when summoned May 16, 2024
@claywar claywar merged commit e85490b into LandSandBoat:base May 16, 2024
11 of 12 checks passed
@ampitere ampitere deleted the fix_pets_not_engaging_with_master branch May 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants